Skip to content

Commit 0b6203c

Browse files
ttaylorrgitster
authored andcommitted
t/lib-bitmap.sh: avoid silencing stderr
The midx_bitmap_partial_tests() function is responsible for setting up a state where some (but not all) packs in the repository are covered by a MIDX (and bitmap). This function has redirected the `git multi-pack-index write --bitmap`'s stderr to a file "err" since its introduction back in c51f5a6 (t5326: test multi-pack bitmap behavior, 2021-08-31). This was likely a stray change left over from a slightly different version of this test, since the file "err" is never read after being written. This leads to confusingly-missing output, especially when the contents of stderr are important. Resolve this confusion by avoiding silencing stderr in this case. Signed-off-by: Taylor Blau <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 65168c4 commit 0b6203c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/lib-bitmap.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ midx_bitmap_partial_tests () {
440440
test_commit packed &&
441441
git repack &&
442442
test_commit loose &&
443-
git multi-pack-index write --bitmap 2>err &&
443+
git multi-pack-index write --bitmap &&
444444
test_path_is_file $midx &&
445445
test_path_is_file $midx-$(midx_checksum $objdir).bitmap
446446
'

0 commit comments

Comments
 (0)