pack-bitmap: remove checks before bitmap_free

brandb97 · brandb97 · commit 19677bcbc3da · 2025-05-25T11:45:02.000+08:00
In pack-bitmap.c:find_boundary_objects, we build a roots_bitmap and
cascade it to cb.base. However, I’m wondering why we only free
roots_bitmap when the cascade succeeds. It seems we could safely remove
this check and always free roots_bitmap afterward, which might provide
some performance benefits.

Signed-off-by: Lidong Yan &lt;502024330056@smail.nju.edu.cn&gt;
diff --git a/pack-bitmap.c b/pack-bitmap.c
@@ -1363,8 +1363,8 @@ static struct bitmap *find_boundary_objects(struct bitmap_index *bitmap_git,
 			bitmap_set(roots_bitmap, pos);
 		}
 
-		if (!cascade_pseudo_merges_1(bitmap_git, cb.base, roots_bitmap))
-			bitmap_free(roots_bitmap);
+		cascade_pseudo_merges_1(bitmap_git, cb.base, roots_bitmap);
+		bitmap_free(roots_bitmap);
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -1363,8 +1363,8 @@ static struct bitmap find_boundary_objects(struct bitmap_index bitmap_git,`
`1363`	`1363`	`bitmap_set(roots_bitmap, pos);`
`1364`	`1364`	`}`
`1365`	`1365`
`1366`		`- if (!cascade_pseudo_merges_1(bitmap_git, cb.base, roots_bitmap))`
`1367`		`- bitmap_free(roots_bitmap);`
	`1366`	`+ cascade_pseudo_merges_1(bitmap_git, cb.base, roots_bitmap);`
	`1367`	`+ bitmap_free(roots_bitmap);`
`1368`	`1368`	`}`
`1369`	`1369`
`1370`	`1370`	`/*`