builtin/submodule--helper: fix leaking refs on push-check

pks-t · gitster · commit 1e8cb17ac5c0 · 2024-09-05T08:49:11.000-07:00
In the push-check subcommand of the submodule helper we acquire a list
of local refs, but never free that list. Fix this memory leak.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
@@ -2958,7 +2958,9 @@ static int push_check(int argc, const char **argv, const char *prefix UNUSED)
 				    rs->src);
 			}
 		}
+
 		refspec_clear(&refspec);
+		free_refs(local_refs);
 	}
 	free(head);
 
diff --git a/t/t5531-deep-submodule-push.sh b/t/t5531-deep-submodule-push.sh
@@ -8,6 +8,7 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 GIT_TEST_FATAL_REGISTER_SUBMODULE_ODB=1
 export GIT_TEST_FATAL_REGISTER_SUBMODULE_ODB
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success setup '

Original file line number	Diff line number	Diff line change
`@@ -2958,7 +2958,9 @@ static int push_check(int argc, const char *argv, const char prefix UNUSED)`
`2958`	`2958`	`rs->src);`
`2959`	`2959`	`}`
`2960`	`2960`	`}`
	`2961`	`+`
`2961`	`2962`	`refspec_clear(&refspec);`
	`2963`	`+ free_refs(local_refs);`
`2962`	`2964`	`}`
`2963`	`2965`	`free(head);`
`2964`	`2966`