Skip to content

Commit 1fd8822

Browse files
avargitster
authored andcommitted
transport: use designated initializers
Change the assignments to the various transport_vtables to use designated initializers, this makes the code easier to read and maintain. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9b1cdd3 commit 1fd8822

File tree

2 files changed

+18
-24
lines changed

2 files changed

+18
-24
lines changed

transport-helper.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1261,12 +1261,12 @@ static struct ref *get_refs_list_using_list(struct transport *transport,
12611261
}
12621262

12631263
static struct transport_vtable vtable = {
1264-
set_helper_option,
1265-
get_refs_list,
1266-
fetch_refs,
1267-
push_refs,
1268-
connect_helper,
1269-
release_helper
1264+
.set_option = set_helper_option,
1265+
.get_refs_list = get_refs_list,
1266+
.fetch_refs = fetch_refs,
1267+
.push_refs = push_refs,
1268+
.connect = connect_helper,
1269+
.disconnect = release_helper
12701270
};
12711271

12721272
int transport_helper_init(struct transport *transport, const char *name)

transport.c

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -883,12 +883,10 @@ static int disconnect_git(struct transport *transport)
883883
}
884884

885885
static struct transport_vtable taken_over_vtable = {
886-
NULL,
887-
get_refs_via_connect,
888-
fetch_refs_via_pack,
889-
git_transport_push,
890-
NULL,
891-
disconnect_git
886+
.get_refs_list = get_refs_via_connect,
887+
.fetch_refs = fetch_refs_via_pack,
888+
.push_refs = git_transport_push,
889+
.disconnect = disconnect_git
892890
};
893891

894892
void transport_take_over(struct transport *transport,
@@ -1032,21 +1030,17 @@ void transport_check_allowed(const char *type)
10321030
}
10331031

10341032
static struct transport_vtable bundle_vtable = {
1035-
NULL,
1036-
get_refs_from_bundle,
1037-
fetch_refs_from_bundle,
1038-
NULL,
1039-
NULL,
1040-
close_bundle
1033+
.get_refs_list = get_refs_from_bundle,
1034+
.fetch_refs = fetch_refs_from_bundle,
1035+
.disconnect = close_bundle
10411036
};
10421037

10431038
static struct transport_vtable builtin_smart_vtable = {
1044-
NULL,
1045-
get_refs_via_connect,
1046-
fetch_refs_via_pack,
1047-
git_transport_push,
1048-
connect_git,
1049-
disconnect_git
1039+
.get_refs_list = get_refs_via_connect,
1040+
.fetch_refs = fetch_refs_via_pack,
1041+
.push_refs = git_transport_push,
1042+
.connect = connect_git,
1043+
.disconnect = disconnect_git
10501044
};
10511045

10521046
struct transport *transport_get(struct remote *remote, const char *url)

0 commit comments

Comments
 (0)