Skip to content

Commit 29fe658

Browse files
LemmingAvalanchegitster
authored andcommitted
Makefile: don’t add whatchanged after it has been removed
07572f2 (whatchanged: remove when built with WITH_BREAKING_CHANGES, 2025-05-12) set up the removal of git-whatchanged(1) when `WITH_BREAKING_CHANGES` is active. Part of that work was removing it from `commands` in `git.c`. But the Makefile still lists it as a builtin. That leaves it in the limbo of being linked but not being callable; you get the generic error about not being able to call it as a *builtin*: $ git whatchanged fatal: cannot handle whatchanged as a builtin instead of the expected: $ git whatchanged git: 'whatchanged' is not a git command. See 'git --help'. Based-on-patch-by: Jeff King <[email protected]> Signed-off-by: Kristoffer Haugsbakk <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent c44beea commit 29fe658

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,9 @@ BUILT_INS += git-stage$X
883883
BUILT_INS += git-status$X
884884
BUILT_INS += git-switch$X
885885
BUILT_INS += git-version$X
886+
ifndef WITH_BREAKING_CHANGES
886887
BUILT_INS += git-whatchanged$X
888+
endif
887889

888890
# what 'all' will build but not install in gitexecdir
889891
OTHER_PROGRAMS += git$X

0 commit comments

Comments
 (0)