Skip to content

Commit 5626558

Browse files
committed
t4040: remove test that succeeded for a wrong reason
"diff-tree -b --exit-code" without "--patch" exits with 0 status, not because it finds that the two input files are equivalent while ignoring whitespaces, but because the implied "--raw" mode always exits with 0 when whitespace tweaking options like "-b" and "-w" are given, which is a long-standing bug. We are about to fix it so that "--raw" and friends report the differences with the exit status (even though they ignore the whitespace tweaking options when producing their output), which will make this test, which succeeded for a wrong reason, start failing. Remove it. Signed-off-by: Junio C Hamano <[email protected]>
1 parent e8efd86 commit 5626558

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

t/t4040-whitespace-status.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ test_expect_success 'diff-tree --exit-code' '
2828

2929
test_expect_success 'diff-tree -b --exit-code' '
3030
git diff -b --exit-code HEAD^ HEAD &&
31-
git diff-tree -b -p --exit-code HEAD^ HEAD &&
32-
git diff-tree -b --exit-code HEAD^ HEAD
31+
git diff-tree -b -p --exit-code HEAD^ HEAD
3332
'
3433

3534
test_expect_success 'diff-index --cached --exit-code' '

0 commit comments

Comments
 (0)