remote-curl: fix memory leak in discover_refs() error paths

When discover_refs() encounters an HTTP error, it calls
show_http_message() which may re-encode the buffer via
strbuf_reencode(), allocating new memory. The function then
immediately calls die() to exit, bypassing the cleanup code
at the end of the function that releases all allocated strbufs
and string_list resources.

This results in a memory leak detected by LeakSanitizer in the
re-encoded buffer allocated by reencode_string_iconv().

Fix this by releasing all allocated resources (refs_url, type,
charset, effective_url, buffer, protocol_header strbufs, and
extra_headers string_list) before calling die() in each error
case (HTTP_MISSING_TARGET, HTTP_NOAUTH, HTTP_NOMATCHPUBLICKEY,
HTTP_RATE_LIMITED, and the default case).

Signed-off-by: Vaidas Pilkauskas <[email protected]>

Author: vaidas-shopify

remote-curl.c

@@ -519,22 +519,57 @@ static struct discovery *discover_refs(const char *service, int for_push)
 		break;
 	case HTTP_MISSING_TARGET:
 		show_http_message(&type, &charset, &buffer);
+		strbuf_release(&refs_url);
+		strbuf_release(&type);
+		strbuf_release(&charset);
+		strbuf_release(&effective_url);
+		strbuf_release(&buffer);
+		strbuf_release(&protocol_header);
+		string_list_clear(&extra_headers, 0);
 		die(_("repository '%s' not found"),
 		    transport_anonymize_url(url.buf));
 	case HTTP_NOAUTH:
 		show_http_message(&type, &charset, &buffer);
+		strbuf_release(&refs_url);
+		strbuf_release(&type);
+		strbuf_release(&charset);
+		strbuf_release(&effective_url);
+		strbuf_release(&buffer);
+		strbuf_release(&protocol_header);
+		string_list_clear(&extra_headers, 0);
 		die(_("Authentication failed for '%s'"),
 		    transport_anonymize_url(url.buf));
 	case HTTP_NOMATCHPUBLICKEY:
 		show_http_message(&type, &charset, &buffer);
+		strbuf_release(&refs_url);
+		strbuf_release(&type);
+		strbuf_release(&charset);
+		strbuf_release(&effective_url);
+		strbuf_release(&buffer);
+		strbuf_release(&protocol_header);
+		string_list_clear(&extra_headers, 0);
 		die(_("unable to access '%s' with http.pinnedPubkey configuration: %s"),
 		    transport_anonymize_url(url.buf), curl_errorstr);
 	case HTTP_RATE_LIMITED:
 		show_http_message(&type, &charset, &buffer);
+		strbuf_release(&refs_url);
+		strbuf_release(&type);
+		strbuf_release(&charset);
+		strbuf_release(&effective_url);
+		strbuf_release(&buffer);
+		strbuf_release(&protocol_header);
+		string_list_clear(&extra_headers, 0);
 		die(_("rate limited by '%s', please try again later"),
 		    transport_anonymize_url(url.buf));
 	default:
 		show_http_message(&type, &charset, &buffer);
+		strbuf_release(&refs_url);
+		strbuf_release(&type);
+		strbuf_release(&charset);
+		strbuf_release(&effective_url);
+		strbuf_release(&buffer);
+		strbuf_release(&protocol_header);
+		string_list_clear(&extra_headers, 0);
 		die(_("unable to access '%s': %s"),
 		    transport_anonymize_url(url.buf), curl_errorstr);
 	}