revision: fix memory leak in prepare_show_merge()

brandb97 · brandb97 · commit 5d213e2c11ca · 2025-06-04T10:34:20.000+08:00
In revision.c:prepare_show_merge(), we allocated an array in prune
but forget to free it. Since parse_pathspec is not responsible to
free prune, we should add `free(prune)` in the end of prepare_show_merge().

Signed-off-by: Lidong Yan &lt;502024330056@smail.nju.edu.cn&gt;
diff --git a/revision.c b/revision.c
@@ -2060,6 +2060,7 @@ static void prepare_show_merge(struct rev_info *revs)
 	parse_pathspec(&revs->prune_data, PATHSPEC_ALL_MAGIC & ~PATHSPEC_LITERAL,
 		       PATHSPEC_PREFER_FULL | PATHSPEC_LITERAL_PATH, "", prune);
 	revs->limited = 1;
+	free(prune);
 }
 
 static int dotdot_missing(const char *arg, char *dotdot,

Original file line number	Diff line number	Diff line change
`@@ -2060,6 +2060,7 @@ static void prepare_show_merge(struct rev_info *revs)`
`2060`	`2060`	`parse_pathspec(&revs->prune_data, PATHSPEC_ALL_MAGIC & ~PATHSPEC_LITERAL,`
`2061`	`2061`	`PATHSPEC_PREFER_FULL \| PATHSPEC_LITERAL_PATH, "", prune);`
`2062`	`2062`	`revs->limited = 1;`
	`2063`	`+ free(prune);`
`2063`	`2064`	`}`
`2064`	`2065`
`2065`	`2066`	`static int dotdot_missing(const char arg, char dotdot,`