Skip to content

Commit 5e22d03

Browse files
committed
Merge branch 'ly/fetch-pack-leakfix'
A memory-leak in an error code path has been plugged. * ly/fetch-pack-leakfix: builtin/fetch-pack: cleanup before return error
2 parents b5a135b + aedebdb commit 5e22d03

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

builtin/fetch-pack.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,10 @@ int cmd_fetch_pack(int argc,
274274
}
275275
close(fd[0]);
276276
close(fd[1]);
277-
if (finish_connect(conn))
278-
return 1;
277+
if (finish_connect(conn)) {
278+
ret = 1;
279+
goto cleanup;
280+
}
279281

280282
ret = !fetched_refs;
281283

@@ -291,6 +293,7 @@ int cmd_fetch_pack(int argc,
291293
printf("%s %s\n",
292294
oid_to_hex(&ref->old_oid), ref->name);
293295

296+
cleanup:
294297
for (size_t i = 0; i < nr_sought; i++)
295298
free_one_ref(sought_to_free[i]);
296299
free(sought_to_free);

0 commit comments

Comments
 (0)