submodule--helper: fix "errmsg_str" memory leak

avar · gitster · commit 61adac6c4b58 · 2022-09-02T09:18:12.000-07:00
Fix a memory leak introduced in e83e333 (submodule: port submodule subcommand 'summary' from shell to C, 2020-08-13), we sometimes append to the "errmsg", and need to free the "struct strbuf". Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Reviewed-by: Glen Choo <chooglen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
@@ -973,6 +973,7 @@ static void generate_submodule_summary(struct summary_cb *info,
 	free(displaypath);
 	free(src_abbrev);
 	free(dst_abbrev);
+	strbuf_release(&errmsg);
 }
 
 static void prepare_submodule_summary(struct summary_cb *info,

Original file line number	Diff line number	Diff line change
`@@ -973,6 +973,7 @@ static void generate_submodule_summary(struct summary_cb *info,`
`973`	`973`	`free(displaypath);`
`974`	`974`	`free(src_abbrev);`
`975`	`975`	`free(dst_abbrev);`
	`976`	`+ strbuf_release(&errmsg);`
`976`	`977`	`}`
`977`	`978`
`978`	`979`	`static void prepare_submodule_summary(struct summary_cb *info,`