Skip to content

Commit 6d00680

Browse files
avargitster
authored andcommitted
test-lib: use $1, not $@ in test_known_broken_{ok,failure}_
Clarify that these two functions never take N arguments, they'll only ever receive one. They've needlessly used $@ over $1 since 41ac414 (Sane use of test_expect_failure, 2008-02-01). In the future we might want to pass the test source to these, but now that's not the case. This preparatory change helps to clarify a follow-up change. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6a475b7 commit 6d00680

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

t/test-lib.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -804,14 +804,14 @@ test_failure_ () {
804804

805805
test_known_broken_ok_ () {
806806
test_fixed=$(($test_fixed+1))
807-
say_color error "ok $test_count - $@ # TODO known breakage vanished"
808-
finalize_test_case_output fixed "$@"
807+
say_color error "ok $test_count - $1 # TODO known breakage vanished"
808+
finalize_test_case_output fixed "$1"
809809
}
810810

811811
test_known_broken_failure_ () {
812812
test_broken=$(($test_broken+1))
813-
say_color warn "not ok $test_count - $@ # TODO known breakage"
814-
finalize_test_case_output broken "$@"
813+
say_color warn "not ok $test_count - $1 # TODO known breakage"
814+
finalize_test_case_output broken "$1"
815815
}
816816

817817
test_debug () {

0 commit comments

Comments
 (0)