Skip to content

Commit 7b34164

Browse files
phillipwoodgitster
authored andcommitted
ci(github): restore "print test failures" step name
As well as removing the explicit shell setting d8b21a0 (CI: don't explicitly pick "bash" shell outside of Windows, fix regression, 2022-12-07) also reverted the name of the print test failures step introduced by 5aeb145 (ci(github): bring back the 'print test failures' step, 2022-06-08). This is unfortunate as 5aeb145 added a message to direct contributors to the "print test failures" step when a test fails and that step is no-longer known by that name on the non-windows ci jobs. In principle we could update the message to print the correct name for the step but then we'd have to deal with having two different names for the same step on different jobs. It is simpler for the implementation and contributors to use the same name for this step on all jobs. Signed-off-by: Phillip Wood <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d8b21a0 commit 7b34164

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,9 @@ jobs:
261261
- uses: actions/checkout@v2
262262
- run: ci/install-dependencies.sh
263263
- run: ci/run-build-and-tests.sh
264-
- run: ci/print-test-failures.sh
264+
- name: print test failures
265265
if: failure() && env.FAILED_TEST_ARTIFACTS != ''
266+
run: ci/print-test-failures.sh
266267
- name: Upload failed tests' directories
267268
if: failure() && env.FAILED_TEST_ARTIFACTS != ''
268269
uses: actions/upload-artifact@v2
@@ -292,8 +293,9 @@ jobs:
292293
- uses: actions/checkout@v1
293294
- run: ci/install-docker-dependencies.sh
294295
- run: ci/run-build-and-tests.sh
295-
- run: ci/print-test-failures.sh
296+
- name: print test failures
296297
if: failure() && env.FAILED_TEST_ARTIFACTS != ''
298+
run: ci/print-test-failures.sh
297299
- name: Upload failed tests' directories
298300
if: failure() && env.FAILED_TEST_ARTIFACTS != ''
299301
uses: actions/upload-artifact@v1

0 commit comments

Comments
 (0)