tr2: remove NEEDSWORK comment for "non-procfs" implementations

avar · gitster · commit 7d9c80f62673 · 2021-09-07T11:07:59.000-07:00
I'm fairly sure that there is no way on Linux to inspect the process tree without using procfs, any tool such as ps(1), top(1) etc. that shows this sort of information ultimately looks the information up in procfs. So let's remove this comment added in 2f732bf (tr2: log parent process name, 2021-07-21), it's setting us up for an impossible task. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Acked-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/compat/linux/procinfo.c b/compat/linux/procinfo.c
@@ -25,7 +25,6 @@ static void get_ancestry_names(struct strvec *names)
 	}
 
 	return;
-	/* NEEDSWORK: add non-procfs-linux implementations here */
 }
 
 void trace2_collect_process_info(enum trace2_process_info_reason reason)

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ static void get_ancestry_names(struct strvec *names)`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`return;`
`28`		`- /* NEEDSWORK: add non-procfs-linux implementations here */`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`void trace2_collect_process_info(enum trace2_process_info_reason reason)`