Skip to content

Commit 7dac3f8

Browse files
bebarinogitster
authored andcommitted
gpg: close stderr once finished with it in verify_signed_buffer()
Failing to close the stderr pipe in verify_signed_buffer() causes git to run out of file descriptors if there are many calls to verify_signed_buffer(). An easy way to trigger this is to run git log --show-signature --merges | grep "key" on the linux kernel git repo. Eventually it will fail with error: cannot create pipe for gpg: Too many open files error: could not run gpg. Close the stderr pipe so that this can't happen. Suggested-by: Jeff King <[email protected]> Signed-off-by: Stephen Boyd <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 2f47eae commit 7dac3f8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

gpg-interface.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,10 @@ int verify_signed_buffer(const char *payload, size_t payload_size,
128128
write_in_full(gpg.in, payload, payload_size);
129129
close(gpg.in);
130130

131-
if (gpg_output)
131+
if (gpg_output) {
132132
strbuf_read(gpg_output, gpg.err, 0);
133+
close(gpg.err);
134+
}
133135
ret = finish_command(&gpg);
134136

135137
unlink_or_warn(path);

0 commit comments

Comments
 (0)