Skip to content

Commit 811b8a3

Browse files
committed
gitk: use themed spinboxes
gitk uses classic (non-themed) spinboxes rather than the ttk variants. Commit d93f171 ("gitk: Use themed tk widgets", 2009-04-17) that added ttk makes no mention of why ttk:spinboxes were omitted, but this leads to an inconsistent interface. Let's use the ttk version. Signed-off-by: Mark Levedahl <[email protected]>
1 parent ac8fec7 commit 811b8a3

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

gitk

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2656,7 +2656,7 @@ proc makewindow {} {
26562656
26572657
ttk::label .bleft.mid.labeldiffcontext -text " [mc "Lines of context"]: "
26582658
pack .bleft.mid.diff .bleft.mid.old .bleft.mid.new -side left -ipadx $wgap
2659-
spinbox .bleft.mid.diffcontext -width 5 \
2659+
ttk::spinbox .bleft.mid.diffcontext -width 5 \
26602660
-from 0 -increment 1 -to 10000000 \
26612661
-validate all -validatecommand "diffcontextvalidate %P" \
26622662
-textvariable diffcontextstring
@@ -11692,11 +11692,11 @@ proc prefspage_general {notebook} {
1169211692
grid $page.ldisp - -sticky w -pady 10
1169311693
ttk::label $page.spacer -text " "
1169411694
ttk::label $page.maxwidthl -text [mc "Maximum graph width (lines)"]
11695-
spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth
11695+
ttk::spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth
1169611696
grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w
1169711697
#xgettext:no-tcl-format
1169811698
ttk::label $page.maxpctl -text [mc "Maximum graph width (% of pane)"]
11699-
spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct
11699+
ttk::spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct
1170011700
grid x $page.maxpctl $page.maxpct -sticky w
1170111701
ttk::checkbutton $page.showlocal -text [mc "Show local changes"] \
1170211702
-variable showlocalchanges
@@ -11721,17 +11721,17 @@ proc prefspage_general {notebook} {
1172111721
grid x $page.autoselect -sticky w
1172211722
}
1172311723
11724-
spinbox $page.autosellen -from 1 -to $hashlength -width 4 -textvariable autosellen
11724+
ttk::spinbox $page.autosellen -from 1 -to $hashlength -width 4 -textvariable autosellen
1172511725
ttk::label $page.autosellenl -text [mc "Length of commit ID to copy"]
1172611726
grid x $page.autosellenl $page.autosellen -sticky w
1172711727
ttk::label $page.kscroll1 -text [mc "Wheel scrolling multiplier"]
11728-
spinbox $page.kscroll -from 1 -to 20 -width 4 -textvariable kscroll
11728+
ttk::spinbox $page.kscroll -from 1 -to 20 -width 4 -textvariable kscroll
1172911729
grid x $page.kscroll1 $page.kscroll -sticky w
1173011730
1173111731
ttk::label $page.ddisp -text [mc "Diff display options"] -font mainfontbold
1173211732
grid $page.ddisp - -sticky w -pady 10
1173311733
ttk::label $page.tabstopl -text [mc "Tab spacing"]
11734-
spinbox $page.tabstop -from 1 -to 20 -width 4 -textvariable tabstop
11734+
ttk::spinbox $page.tabstop -from 1 -to 20 -width 4 -textvariable tabstop
1173511735
grid x $page.tabstopl $page.tabstop -sticky w
1173611736
1173711737
ttk::label $page.wrapcommentl -text [mc "Wrap comment text"]
@@ -11746,7 +11746,7 @@ proc prefspage_general {notebook} {
1174611746
-variable showneartags
1174711747
grid x $page.ntag -sticky w
1174811748
ttk::label $page.maxrefsl -text [mc "Maximum # tags/heads to show"]
11749-
spinbox $page.maxrefs -from 1 -to 1000 -width 4 -textvariable maxrefs
11749+
ttk::spinbox $page.maxrefs -from 1 -to 1000 -width 4 -textvariable maxrefs
1175011750
grid x $page.maxrefsl $page.maxrefs -sticky w
1175111751
ttk::checkbutton $page.ldiff -text [mc "Limit diffs to listed paths"] \
1175211752
-variable limitdiffs

0 commit comments

Comments
 (0)