Skip to content

Commit 836088d

Browse files
peffgitster
authored andcommitted
doc-diff: drop SOURCE_DATE_EPOCH override
The original doc-diff script set SOURCE_DATE_EPOCH to make asciidoc's output deterministic. Otherwise, the mtime of the source files would end up in the footer of the manpage, causing noisy and uninteresting diff hunks. But this has been unused since 28fde3a (doc: set actual revdate for manpages, 2023-04-13), as the footer uses the externally-specified GIT_DATE instead (that needs to be set consistently, too, which it now is as of the previous commit). Asciidoc sets several automatic attributes based on the mtime (or manual epoch), so it's still possible to write a document that would need SOURCE_DATE_EPOCH set to be deterministic. But if we wrote such a thing, it's probably a mistake, and we're better off having doc-diff loudly show it. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1c301bc commit 836088d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Documentation/doc-diff

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ render_tree () {
154154
$makemanflags \
155155
GIT_VERSION=omitted \
156156
GIT_DATE=1970-01-01 \
157-
SOURCE_DATE_EPOCH=0 \
158157
DESTDIR="$tmp/installed/$dname+" \
159158
install-man &&
160159
mv "$tmp/installed/$dname+" "$tmp/installed/$dname"

0 commit comments

Comments
 (0)