builtin/repack: fix leaking line buffer when packing promisors

pks-t · gitster · commit 860b6780163a · 2024-09-05T08:49:12.000-07:00
In `repack_promisor_objects()` we read output from git-pack-objects(1)
line by line, using `strbuf_getline_lf()`. We never free the line
buffer, causing a memory leak. Plug it.

This leak is being hit in t5616, but plugging it alone is not
sufficient to make the whole test suite leak free.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/repack.c b/builtin/repack.c
@@ -425,9 +425,11 @@ static void repack_promisor_objects(const struct pack_objects_args *args,
 
 		free(promisor_name);
 	}
+
 	fclose(out);
 	if (finish_command(&cmd))
 		die(_("could not finish pack-objects to repack promisor objects"));
+	strbuf_release(&line);
 }
 
 struct pack_geometry {

Original file line number	Diff line number	Diff line change
`@@ -425,9 +425,11 @@ static void repack_promisor_objects(const struct pack_objects_args *args,`
`425`	`425`
`426`	`426`	`free(promisor_name);`
`427`	`427`	`}`
	`428`	`+`
`428`	`429`	`fclose(out);`
`429`	`430`	`if (finish_command(&cmd))`
`430`	`431`	`die(_("could not finish pack-objects to repack promisor objects"));`
	`432`	`+ strbuf_release(&line);`
`431`	`433`	`}`
`432`	`434`
`433`	`435`	`struct pack_geometry {`