repository: BUG when is_bare_cfg is not initialized

John Cai · gitster · commit 877121440646 · 2024-11-07T13:27:46.000+09:00
The is_bare_cfg member of the repository struct should be properly
initiated when setting up a repository. BUG when repo_is_bare() sees
that the flag has not been set.

Signed-off-by: John Cai &lt;johncai86@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/repository.c b/repository.c
@@ -464,5 +464,7 @@ int repo_hold_locked_index(struct repository *repo,
 int repo_is_bare(struct repository *repo)
 {
 	/* if core.bare is not 'false', let's see if there is a work tree */
+	if (repo->is_bare_cfg < 0 )
+		BUG("is_bare_cfg unspecified");
 	return repo->is_bare_cfg && !repo_get_work_tree(repo);
 }

Original file line number	Diff line number	Diff line change
`@@ -464,5 +464,7 @@ int repo_hold_locked_index(struct repository *repo,`
`464`	`464`	`int repo_is_bare(struct repository *repo)`
`465`	`465`	`{`
`466`	`466`	`/* if core.bare is not 'false', let's see if there is a work tree */`
	`467`	`+ if (repo->is_bare_cfg < 0 )`
	`468`	`+ BUG("is_bare_cfg unspecified");`
`467`	`469`	`return repo->is_bare_cfg && !repo_get_work_tree(repo);`
`468`	`470`	`}`