Skip to content

Commit 8775279

Browse files
committed
Merge branch 'jn/mergetool-hideresolved-is-optional'
Disable the recent mergetool's hideresolved feature by default for backward compatibility and safety. * jn/mergetool-hideresolved-is-optional: doc: describe mergetool configuration in git-mergetool(1) mergetool: do not enable hideResolved by default
2 parents 074d162 + 5320406 commit 8775279

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

Documentation/config/mergetool.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ mergetool.hideResolved::
5353
resolution. This flag causes 'LOCAL' and 'REMOTE' to be overwriten so
5454
that only the unresolved conflicts are presented to the merge tool. Can
5555
be configured per-tool via the `mergetool.<tool>.hideResolved`
56-
configuration variable. Defaults to `true`.
56+
configuration variable. Defaults to `false`.
5757

5858
mergetool.keepBackup::
5959
After performing a merge, the original file with conflict markers

Documentation/git-mergetool.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,10 @@ success of the resolution after the custom tool has exited.
9999
(see linkgit:git-config[1]). To cancel `diff.orderFile`,
100100
use `-O/dev/null`.
101101

102+
CONFIGURATION
103+
-------------
104+
include::config/mergetool.txt[]
105+
102106
TEMPORARY FILES
103107
---------------
104108
`git mergetool` creates `*.orig` backup files while resolving merges.

git-mergetool.sh

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -358,13 +358,8 @@ merge_file () {
358358
enabled=false
359359
fi
360360
else
361-
# The user does not have a preference. Ask the tool.
362-
if hide_resolved_enabled
363-
then
364-
enabled=true
365-
else
366-
enabled=false
367-
fi
361+
# The user does not have a preference. Default to disabled.
362+
enabled=false
368363
fi
369364

370365
if test "$enabled" = true

0 commit comments

Comments
 (0)