reftable: release name on reftable_reader_new() error

rscharfe · gitster · commit 9c47a2b5eea5 · 2025-03-03T08:34:15.000-08:00
If block_source_read_block() or parse_footer() fail, we leak the "name"
member of struct reftable_reader in reftable_reader_new().  Release it.

Reported by: H Z &lt;shiyuyuranzh@gmail.com&gt;
Signed-off-by: René Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/reftable/reader.c b/reftable/reader.c
@@ -666,6 +666,7 @@ int reftable_reader_new(struct reftable_reader **out,
 	reftable_block_done(&footer);
 	reftable_block_done(&header);
 	if (err) {
+		reftable_free(r->name);
 		reftable_free(r);
 		block_source_close(source);
 	}

Original file line number	Diff line number	Diff line change
`@@ -666,6 +666,7 @@ int reftable_reader_new(struct reftable_reader **out,`
`666`	`666`	`reftable_block_done(&footer);`
`667`	`667`	`reftable_block_done(&header);`
`668`	`668`	`if (err) {`
	`669`	`+ reftable_free(r->name);`
`669`	`670`	`reftable_free(r);`
`670`	`671`	`block_source_close(source);`
`671`	`672`	`}`