object-name: fix leaking symlink paths in object context

pks-t · gitster · commit 9ddd5f755d78 · 2024-08-14T10:07:57.000-07:00
The object context may be populated with symlink contents when reading a
symlink, but the associated strbuf doesn't ever get released when
releasing the object context, causing a memory leak. Plug it.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/object-name.c b/object-name.c
@@ -1765,6 +1765,7 @@ int strbuf_check_branch_ref(struct strbuf *sb, const char *name)
 void object_context_release(struct object_context *ctx)
 {
 	free(ctx->path);
+	strbuf_release(&ctx->symlink_path);
 }
 
 /*
diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
@@ -2,6 +2,7 @@
 
 test_description='git cat-file'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_cmdmode_usage () {

Original file line number	Diff line number	Diff line change
`@@ -1765,6 +1765,7 @@ int strbuf_check_branch_ref(struct strbuf sb, const char name)`
`1765`	`1765`	`void object_context_release(struct object_context *ctx)`
`1766`	`1766`	`{`
`1767`	`1767`	`free(ctx->path);`
	`1768`	`+ strbuf_release(&ctx->symlink_path);`
`1768`	`1769`	`}`
`1769`	`1770`
`1770`	`1771`	`/*`