refspec.c: make valid_fetch_refspec() file-scope static

f2c6fda (refs: consolidate remote name validation, 2020-10-01)
moved valid_remote_name(), which receives the name the user gave to
"git remote add <name>" and checks if it is a name that we allow to
name a remote, to this file, even though it would have been a better
fit in remote.c file.  The function was the only caller of the
helper function valid_fetch_refspec() defined in this file, and in
the 4 years or so since then, we have not added any new callers to
the latter.

It could be argued that we should move valid_remote_name() to
remote.c someday, which would make it necessary for this function to
be public, but it is simpler to let the caller to stay there and
reduce the number of public functions by one.

Signed-off-by: Junio C Hamano <[email protected]>

Author: gitster

refspec.c

@@ -233,7 +233,7 @@ void refspec_clear(struct refspec *rs)
 	rs->fetch = 0;
 }
 
-int valid_fetch_refspec(const char *fetch_refspec_str)
+static int valid_fetch_refspec(const char *fetch_refspec_str)
 {
 	struct refspec_item refspec;
 	int ret = refspec_item_init(&refspec, fetch_refspec_str, REFSPEC_FETCH);

refspec.h

@@ -62,7 +62,6 @@ void refspec_appendf(struct refspec *rs, const char *fmt, ...);
 void refspec_appendn(struct refspec *rs, const char **refspecs, int nr);
 void refspec_clear(struct refspec *rs);
 
-int valid_fetch_refspec(const char *refspec);
 int valid_remote_name(const char *name);
 
 struct strvec;