Merge branch 'vd/pthread-setspecific-g11-fix'

gitster · gitster · commit a73934c32094 · 2021-11-04T12:07:47.000-07:00
One CI task based on Fedora image noticed a not-quite-kosher
consturct recently, which has been corrected.

* vd/pthread-setspecific-g11-fix:
  async_die_is_recursing: work around GCC v11.x issue on Fedora
diff --git a/run-command.c b/run-command.c
@@ -1099,7 +1099,7 @@ static NORETURN void die_async(const char *err, va_list params)
 static int async_die_is_recursing(void)
 {
 	void *ret = pthread_getspecific(async_die_counter);
-	pthread_setspecific(async_die_counter, (void *)1);
+	pthread_setspecific(async_die_counter, &async_die_counter); /* set to any non-NULL valid pointer */
 	return ret != NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1099,7 +1099,7 @@ static NORETURN void die_async(const char *err, va_list params)`
`1099`	`1099`	`static int async_die_is_recursing(void)`
`1100`	`1100`	`{`
`1101`	`1101`	`void *ret = pthread_getspecific(async_die_counter);`
`1102`		`- pthread_setspecific(async_die_counter, (void *)1);`
	`1102`	`+ pthread_setspecific(async_die_counter, &async_die_counter); /* set to any non-NULL valid pointer */`
`1103`	`1103`	`return ret != NULL;`
`1104`	`1104`	`}`
`1105`	`1105`