Skip to content

Commit ab7c7c2

Browse files
dschogitster
authored andcommitted
remote: warn about unhandled branch.<name>.rebase values
We ignore them silently, but it actually makes sense to warn the users that their config setting has no effect. Signed-off-by: Johannes Schindelin <[email protected]> Reviewed-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6df8755 commit ab7c7c2

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

builtin/remote.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,9 @@ static int config_read_branches(const char *key, const char *value, void *cb)
318318
* truth value with >= REBASE_TRUE.
319319
*/
320320
info->rebase = rebase_parse_value(value);
321+
if (info->rebase == REBASE_INVALID)
322+
warning(_("unhandled branch.%s.rebase=%s; assuming "
323+
"'true'"), name, value);
321324
break;
322325
case PUSH_REMOTE:
323326
if (info->push_remote_name)

0 commit comments

Comments
 (0)