Merge branch 'jc/string-list-cleanup' into maint

gitster · gitster · commit b0fd38a5159f · 2022-08-10T21:52:36.000-07:00
Code clean-up.
source: &lt;xmqq7d471dns.fsf@gitster.g&gt;

* jc/string-list-cleanup:
  builtin/remote.c: use the right kind of STRING_LIST_INIT
diff --git a/builtin/remote.c b/builtin/remote.c
@@ -1222,10 +1222,9 @@ static int get_one_entry(struct remote *remote, void *priv)
 
 static int show_all(void)
 {
-	struct string_list list = STRING_LIST_INIT_NODUP;
+	struct string_list list = STRING_LIST_INIT_DUP;
 	int result;
 
-	list.strdup_strings = 1;
 	result = for_each_remote(get_one_entry, &list);
 
 	if (!result) {

Original file line number	Diff line number	Diff line change
`@@ -1222,10 +1222,9 @@ static int get_one_entry(struct remote remote, void priv)`
`1222`	`1222`
`1223`	`1223`	`static int show_all(void)`
`1224`	`1224`	`{`
`1225`		`- struct string_list list = STRING_LIST_INIT_NODUP;`
	`1225`	`+ struct string_list list = STRING_LIST_INIT_DUP;`
`1226`	`1226`	`int result;`
`1227`	`1227`
`1228`		`- list.strdup_strings = 1;`
`1229`	`1228`	`result = for_each_remote(get_one_entry, &list);`
`1230`	`1229`
`1231`	`1230`	`if (!result) {`