Skip to content

Commit b359480

Browse files
rybakgitster
authored andcommitted
t6003: uncomment test '--max-age=c3, --topo-order'
Test '--max-age=c3, --topo-order' in t6003-rev-list-topo-order.sh has been commented out as failing since its introduction in [1]. However, the test is successful at least since commit [2] -- bisecting further is harder because of incompatibility of such old Git code with modern header file <openssl/bn.h> [3]. Uncomment this test to gain test coverage. [1] f573571 ([PATCH] Add t/t6003 with some --topo-order tests, 2005-07-07) [2] 765ac8e (Rip out merge-order and make "git log <paths>..." work again., 2006-02-28) [3] BIGNUM used in git's `epoch.c` which was removed in [2] changed significantly between OpenSSL 1.0.2 and OpenSSL 1.1.0 See also https://stackoverflow.com/a/42295243/1083697 and https://lore.kernel.org/git/[email protected]/ Signed-off-by: Andrei Rybak <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent c48035d commit b359480

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

t/t6003-rev-list-topo-order.sh

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -326,19 +326,16 @@ a2
326326
c3
327327
EOF
328328

329-
#
330-
# this test fails on --topo-order - a fix is required
331-
#
332-
#test_output_expect_success '--max-age=c3, --topo-order' "git rev-list --topo-order --max-age=$(commit_date c3) l5" <<EOF
333-
#l5
334-
#l4
335-
#l3
336-
#a4
337-
#c3
338-
#b4
339-
#a3
340-
#a2
341-
#EOF
329+
test_output_expect_success '--max-age=c3, --topo-order' "git rev-list --topo-order --max-age=$(commit_date c3) l5" <<EOF
330+
l5
331+
l4
332+
l3
333+
a4
334+
c3
335+
b4
336+
a3
337+
a2
338+
EOF
342339

343340
test_output_expect_success 'one specified head reachable from another a4, c3, --topo-order' "list_duplicates git rev-list --topo-order a4 c3" <<EOF
344341
EOF

0 commit comments

Comments
 (0)