Skip to content

Commit bbb9efe

Browse files
pks-tgitster
authored andcommitted
ci: deduplicate calls to apt-get update
When installing dependencies we first check for the distribution that is in use and then we check for the specific job. In the first step we already install all dependencies required to build and test Git, whereas the second step installs a couple of additional dependencies that are only required to perform job-specific tasks. In both steps we use `apt-get update` to update our repository sources. This is unecessary though: all platforms that use Aptitude would have already executed this command in the distro-specific step anyway. Drop the redundant calls. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1562d9a commit bbb9efe

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

ci/install-dependencies.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,21 +120,17 @@ esac
120120

121121
case "$jobname" in
122122
ClangFormat)
123-
sudo apt-get -q update
124123
sudo apt-get -q -y install clang-format
125124
;;
126125
StaticAnalysis)
127-
sudo apt-get -q update
128126
sudo apt-get -q -y install coccinelle libcurl4-openssl-dev libssl-dev \
129127
libexpat-dev gettext make
130128
;;
131129
sparse)
132-
sudo apt-get -q update -q
133130
sudo apt-get -q -y install libssl-dev libcurl4-openssl-dev \
134131
libexpat-dev gettext zlib1g-dev sparse
135132
;;
136133
Documentation)
137-
sudo apt-get -q update
138134
sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make
139135

140136
test -n "$ALREADY_HAVE_ASCIIDOCTOR" ||

0 commit comments

Comments
 (0)