Skip to content

Commit d17cd97

Browse files
phil-blaingitster
authored andcommitted
p7821: fix test_perf invocation for prereqs
Since 5dccd91 (t/perf: add iteration setup mechanism to perf-lib, 2022-04-04), perf tests need to declare their prerequisites with '--prereq', after the test title. p7821 was forgotten in that commit, such that running that test on a machine where the PCRE prereq is not satisfied aborts the test with: error: bug in the test script: test_wrapper_ needs 2 positional parameters Fix this by correcting the two 'test_perf' invocations in that test suite. Signed-off-by: Philippe Blain <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 683c54c commit d17cd97

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/perf/p7821-grep-engines-fixed.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@ do
3333
fi
3434
if ! test_have_prereq PERF_GREP_ENGINES_THREADS
3535
then
36-
test_perf $prereq "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern" "
36+
test_perf "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern" --prereq "$prereq" "
3737
git -c grep.patternType=$engine grep$GIT_PERF_7821_GREP_OPTS $pattern >'out.$engine' || :
3838
"
3939
else
4040
for threads in $GIT_PERF_GREP_THREADS
4141
do
42-
test_perf PTHREADS,$prereq "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern with $threads threads" "
42+
test_perf "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern with $threads threads" --prereq "PTHREADS,$prereq" "
4343
git -c grep.patternType=$engine -c grep.threads=$threads grep$GIT_PERF_7821_GREP_OPTS $pattern >'out.$engine.$threads' || :
4444
"
4545
done

0 commit comments

Comments
 (0)