Skip to content

Commit dc9f988

Browse files
szedergitster
authored andcommitted
parse-options: drop leading space from '--git-completion-helper' output
The output of 'git <cmd> --git-completion-helper' always starts with a space, e.g.: $ git config --git-completion-helper --global --system --local [...] This doesn't matter for the completion script, because field splitting discards that space anyway. However, later patches in this series will teach parse-options to handle subcommands, and subcommands will be included in the completion helper output as well. This will make the loop printing options (and subcommands) a tad more complex, so I wanted to test the result. The test would have to account for the presence of that leading space, which bugged my OCD, so let's get rid of it. Signed-off-by: SZEDER Gábor <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent a9126b9 commit dc9f988

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

parse-options.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,8 @@ static int show_gitcomp(const struct option *opts, int show_all)
620620
suffix = "=";
621621
if (starts_with(opts->long_name, "no-"))
622622
nr_noopts++;
623-
printf(" --%s%s", opts->long_name, suffix);
623+
printf("%s--%s%s", opts == original_opts ? "" : " ",
624+
opts->long_name, suffix);
624625
}
625626
show_negated_gitcomp(original_opts, show_all, -1);
626627
show_negated_gitcomp(original_opts, show_all, nr_noopts);

0 commit comments

Comments
 (0)