SQUASH??? off by one

gitster · gitster · commit e2f4652d80ab · 2024-12-09T14:26:57.000+09:00
diff --git a/strvec.c b/strvec.c
@@ -66,7 +66,7 @@ void strvec_splice(struct strvec *array, size_t idx, size_t len,
 			array->v = NULL;
 		ALLOC_GROW(array->v, array->nr + (replacement_len - len) + 1,
 			   array->alloc);
-		array->v[array->nr + (replacement_len - len) + 1] = NULL;
+		array->v[array->nr + (replacement_len - len)] = NULL;
 	}
 	for (size_t i = 0; i < len; i++)
 		free((char *)array->v[idx + i]);

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ void strvec_splice(struct strvec *array, size_t idx, size_t len,`
`66`	`66`	`array->v = NULL;`
`67`	`67`	`ALLOC_GROW(array->v, array->nr + (replacement_len - len) + 1,`
`68`	`68`	`array->alloc);`
`69`		`- array->v[array->nr + (replacement_len - len) + 1] = NULL;`
	`69`	`+ array->v[array->nr + (replacement_len - len)] = NULL;`
`70`	`70`	`}`
`71`	`71`	`for (size_t i = 0; i < len; i++)`
`72`	`72`	`free((char *)array->v[idx + i]);`