meson: stop disabling -Wsign-compare

pks-t · gitster · commit eb8728d88ab9 · 2025-01-21T14:20:28.000-08:00
In 4f9264b (config.mak.dev: drop `-Wno-sign-compare`, 2024-12-06) we have started an effort to make our codebase compile with -Wsign-compare. But while we removed the -Wno-sign-compare flag from "config.mak.dev", we didn't adjust the Meson build instructions in the same way. Fix this. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/meson.build b/meson.build
@@ -708,7 +708,6 @@ if get_option('warning_level') in ['2','3', 'everything'] and compiler.get_argum
     # These are disabled because we have these all over the place.
     '-Wno-empty-body',
     '-Wno-missing-field-initializers',
-    '-Wno-sign-compare',
   ]
     if compiler.has_argument(cflag)
       libgit_c_args += cflag

Original file line number	Diff line number	Diff line change
`@@ -708,7 +708,6 @@ if get_option('warning_level') in ['2','3', 'everything'] and compiler.get_argum`
`708`	`708`	`# These are disabled because we have these all over the place.`
`709`	`709`	`'-Wno-empty-body',`
`710`	`710`	`'-Wno-missing-field-initializers',`
`711`		`- '-Wno-sign-compare',`
`712`	`711`	`]`
`713`	`712`	`if compiler.has_argument(cflag)`
`714`	`713`	`libgit_c_args += cflag`