Skip to content

Commit ec60bb9

Browse files
spectral54gitster
authored andcommitted
t6421: fix test to work when repo dir contains d0
The `grep` statement in this test looks for `d0.*<string>`, attempting to filter to only show lines that had tabular output where the 2nd column had `d0` and the final column had a substring of [`git -c `]`fetch.negotiationAlgorithm`. These lines also have `child_start` in the 4th column, but this isn't part of the condition. A subsequent line will have `d1` in the 2nd column, `start` in the 4th column, and `/path/to/git/git -c fetch.negotiationAlgorihm` in the final column. If `/path/to/git/git` contains the substring `d0`, then this line is included by `grep` as well as the desired line, leading to an effective doubling of the number of lines, and test failures. Tighten the grep expression to require `d0` to be surrounded by spaces, and to have the `child_start` label. Signed-off-by: Kyle Lippincott <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b928d57 commit ec60bb9

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

t/t6421-merge-partial-clone.sh

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,9 @@ test_expect_merge_algorithm failure success 'Objects downloaded for single relev
230230
grep fetch_count trace.output | cut -d "|" -f 9 | tr -d " ." >actual &&
231231
test_cmp expect actual &&
232232
233-
# Check the number of fetch commands exec-ed
234-
grep d0.*fetch.negotiationAlgorithm trace.output >fetches &&
233+
# Check the number of fetch commands exec-ed by filtering trace to
234+
# child_start events by the top-level program (2nd field == d0)
235+
grep " d0 .* child_start .*fetch.negotiationAlgorithm" trace.output >fetches &&
235236
test_line_count = 2 fetches &&
236237
237238
git rev-list --objects --all --missing=print |
@@ -318,8 +319,9 @@ test_expect_merge_algorithm failure success 'Objects downloaded when a directory
318319
grep fetch_count trace.output | cut -d "|" -f 9 | tr -d " ." >actual &&
319320
test_cmp expect actual &&
320321
321-
# Check the number of fetch commands exec-ed
322-
grep d0.*fetch.negotiationAlgorithm trace.output >fetches &&
322+
# Check the number of fetch commands exec-ed by filtering trace to
323+
# child_start events by the top-level program (2nd field == d0)
324+
grep " d0 .* child_start .*fetch.negotiationAlgorithm" trace.output >fetches &&
323325
test_line_count = 1 fetches &&
324326
325327
git rev-list --objects --all --missing=print |
@@ -422,8 +424,9 @@ test_expect_merge_algorithm failure success 'Objects downloaded with lots of ren
422424
grep fetch_count trace.output | cut -d "|" -f 9 | tr -d " ." >actual &&
423425
test_cmp expect actual &&
424426
425-
# Check the number of fetch commands exec-ed
426-
grep d0.*fetch.negotiationAlgorithm trace.output >fetches &&
427+
# Check the number of fetch commands exec-ed by filtering trace to
428+
# child_start events by the top-level program (2nd field == d0)
429+
grep " d0 .* child_start .*fetch.negotiationAlgorithm" trace.output >fetches &&
427430
test_line_count = 4 fetches &&
428431
429432
git rev-list --objects --all --missing=print |

0 commit comments

Comments
 (0)