t/helper: fix leaking subrepo in nested submodule config helper

pks-t · gitster · commit f1652c04b5da · 2024-09-27T08:25:35.000-07:00
In the "submodule-nested-repo-config" helper we create a submodule
repository and print its configuration. We do not clear the repo,
causing a memory leak. Plug it.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/helper/test-submodule-nested-repo-config.c b/t/helper/test-submodule-nested-repo-config.c
@@ -29,6 +29,6 @@ int cmd__submodule_nested_repo_config(int argc, const char **argv)
 	print_config_from_gitmodules(&subrepo, argv[2]);
 
 	submodule_free(the_repository);
-
+	repo_clear(&subrepo);
 	return 0;
 }
diff --git a/t/t7411-submodule-config.sh b/t/t7411-submodule-config.sh
@@ -10,6 +10,7 @@ from the database and from the worktree works.
 '
 
 TEST_NO_CREATE_REPO=1
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success 'setup' '

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,6 @@ int cmd__submodule_nested_repo_config(int argc, const char **argv)`
`29`	`29`	`print_config_from_gitmodules(&subrepo, argv[2]);`
`30`	`30`
`31`	`31`	`submodule_free(the_repository);`
`32`		`-`
	`32`	`+ repo_clear(&subrepo);`
`33`	`33`	`return 0;`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ from the database and from the worktree works.`
`10`	`10`	`'`
`11`	`11`
`12`	`12`	`TEST_NO_CREATE_REPO=1`
	`13`	`+TEST_PASSES_SANITIZE_LEAK=true`
`13`	`14`	`. ./test-lib.sh`
`14`	`15`
`15`	`16`	`test_expect_success 'setup' '`