commit-reach: fix trivial memory leak when computing reachability

pks-t · gitster · commit f30bfafcd41d · 2024-08-01T08:47:38.000-07:00
We don't free the local `stack` commit list that we use to compute
reachability of multiple commits at once. Do so.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/commit-reach.c b/commit-reach.c
@@ -1227,4 +1227,5 @@ void tips_reachable_from_bases(struct repository *r,
 done:
 	free(commits);
 	repo_clear_commit_marks(r, SEEN);
+	free_commit_list(stack);
 }
diff --git a/t/t3201-branch-contains.sh b/t/t3201-branch-contains.sh
@@ -2,6 +2,7 @@
 
 test_description='branch --contains <commit>, --no-contains <commit> --merged, and --no-merged'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success setup '

Original file line number	Diff line number	Diff line change
`@@ -1227,4 +1227,5 @@ void tips_reachable_from_bases(struct repository *r,`
`1227`	`1227`	`done:`
`1228`	`1228`	`free(commits);`
`1229`	`1229`	`repo_clear_commit_marks(r, SEEN);`
	`1230`	`+ free_commit_list(stack);`
`1230`	`1231`	`}`