Merge branch 'op/cvsserver-perl-warning' into seen

gitster · gitster · commit fce375080d25 · 2025-05-22T15:04:19.000-07:00
Recent versions of Perl started warning against "! A =~ /pattern/"
which does not negate the result of the matching.

* op/cvsserver-perl-warning:
  cvsserver: avoid precedence problem between ! and %s
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
@@ -5009,7 +5009,7 @@ sub escapeRefName
     #   = "_-xx-" Where "xx" is the hexadecimal representation of the
     #     desired ASCII character byte. (for anything else)
 
-    if(! $refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/)
+    if ($refName !~ /^[1-9][0-9]*(\.[1-9][0-9]*)*$/)
     {
         $refName=~s/_-/_-u--/g;
         $refName=~s/\./_-p-/g;

Original file line number	Diff line number	Diff line change
`@@ -5009,7 +5009,7 @@ sub escapeRefName`
`5009`	`5009`	`# = "_-xx-" Where "xx" is the hexadecimal representation of the`
`5010`	`5010`	`# desired ASCII character byte. (for anything else)`
`5011`	`5011`
`5012`		`- if(! $refName=~/^[1-9][0-9](\.[1-9][0-9])*$/)`
	`5012`	`+ if ($refName !~ /^[1-9][0-9](\.[1-9][0-9])*$/)`
`5013`	`5013`	`{`
`5014`	`5014`	`$refName=~s/_-/_-u--/g;`
`5015`	`5015`	`$refName=~s/\./_-p-/g;`