shallow: handle missing shallow commits gracefully

dscho · gitster · commit ffde052052b7 · 2025-05-15T13:46:02.000-07:00
As pointed out by CodeQL, `lookup_commit()` can return NULL.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/shallow.c b/shallow.c
@@ -705,7 +705,8 @@ void assign_shallow_commits_to_refs(struct shallow_info *info,
 	for (i = 0; i < nr_shallow; i++) {
 		struct commit *c = lookup_commit(the_repository,
 						 &oid[shallow[i]]);
-		c->object.flags |= BOTTOM;
+		if (c)
+			c->object.flags |= BOTTOM;
 	}
 
 	for (i = 0; i < ref->nr; i++)

Original file line number	Diff line number	Diff line change
`@@ -705,7 +705,8 @@ void assign_shallow_commits_to_refs(struct shallow_info *info,`
`705`	`705`	`for (i = 0; i < nr_shallow; i++) {`
`706`	`706`	`struct commit *c = lookup_commit(the_repository,`
`707`	`707`	`&oid[shallow[i]]);`
`708`		`- c->object.flags \|= BOTTOM;`
	`708`	`+ if (c)`
	`709`	`+ c->object.flags \|= BOTTOM;`
`709`	`710`	`}`
`710`	`711`
`711`	`712`	`for (i = 0; i < ref->nr; i++)`