Skip to content

Commit 0299d1b

Browse files
committed
deploy: allow overriding the Azure Function name via a repo variable
This allows overriding the default Azure Function name used for deploying via setting a repository secret (in Settings>Secrets and variables). The name of the Azure Function is treated as a secret because it can be used to derive the URL of the Azure Function and to attempt to DOS it. At this point, it is not _actually_ necessary to provide the correct Azure Function app name here, as we are using a so-called "publish profile" that overrides the app name. However, we are about to switch to Role-Based Access Control, where it very much matters whether the correct name is specified or not. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 449c85e commit 0299d1b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ jobs:
1818
- uses: actions/checkout@v5
1919
- uses: Azure/functions-action@v1
2020
with:
21-
app-name: GitGitGadget
21+
app-name: ${{ secrets.AZURE_FUNCTION_NAME || 'GitGitGadget' }}
2222
publish-profile: ${{ secrets.AZURE_FUNCTIONAPP_PUBLISH_PROFILE }}
2323
respect-funcignore: true

0 commit comments

Comments
 (0)