Trigger the new GitHub workflow to handle PR comments

This _almost_ retires these Azure Pipelines:

- GitGitGadget PR Handler
  https://dev.azure.com/gitgitgadget/git/_build?definitionId=3
- GitGitGadget PR Handler (git)
  https://dev.azure.com/gitgitgadget/git/_build?definitionId=13
- GitGitGadget PR Handler (dscho)
  https://dev.azure.com/gitgitgadget/git/_build?definitionId=12

The remaining responsibility of those Pipelines is to handle PR
_pushes_, which I will address in the next commit.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

GitGitGadget/index.js

@@ -10,8 +10,6 @@
  */
 const { validateGitHubWebHook } = require('./validate-github-webhook');
 
-const { triggerAzurePipeline } = require('./trigger-azure-pipeline');
-
 const { triggerWorkflowDispatch, listWorkflowRuns } = require('./trigger-workflow-dispatch')
 
 module.exports = async (context, req) => {
@@ -29,27 +27,18 @@ module.exports = async (context, req) => {
 
     try {
         /*
-         * The Azure Pipeline needs to be installed as a PR build on _the very
-         * same_ repository that triggers this function. That is, when the
-         * Azure Function triggers GitGitGadget for gitgitgadget/git, it needs
-         * to know that pipelineId 3 is installed on gitgitgadget/git, and
-         * trigger that very pipeline.
-         *
-         * So whenever we extend GitGitGadget to handle another repository, we
-         * will have to add an Azure Pipeline, install it on that repository as
-         * a PR build, and add the information here.
+         * For various reasons, the GitGitGadget GitHub App can be installed
+         * on any random repository. However, GitGitGadget only wants to support
+         * the `gitgitgadget/git` and the `git/git` repository (with the
+         * `dscho/git` one thrown in for debugging purposes).
          */
-        const pipelines = {
-            'dscho': 12,
-            'git': 13,
-            'gitgitgadget': 3,
-        };
+        const orgs = ['gitgitgadget', 'git', 'dscho']
         const a = [context, undefined, 'gitgitgadget-workflows', 'gitgitgadget-workflows']
 
         const eventType = context.req.headers['x-github-event'];
         context.log(`Got eventType: ${eventType}`);
         const repositoryOwner = req.body.repository.owner.login;
-        if (pipelines[repositoryOwner] === undefined) {
+        if (!orgs.includes(repositoryOwner)) {
             context.res = {
                 status: 403,
                 body: 'Refusing to work on a repository other than gitgitgadget/git or git/git'
@@ -95,11 +84,6 @@ module.exports = async (context, req) => {
                 context.res = { body: `push(${req.body.ref}): triggered ${run.html_url}${extra.join('')}` }
             }
         } else if (eventType === 'issue_comment') {
-            const triggerToken = process.env['GITGITGADGET_TRIGGER_TOKEN'];
-            if (!triggerToken) {
-                throw new Error('No configured trigger token');
-            }
-
             const comment = req.body.comment;
             const prNumber = req.body.issue.number;
             if (!comment || !comment.id || !prNumber) {
@@ -121,19 +105,13 @@ module.exports = async (context, req) => {
                 return;
             }
 
-            const sourceBranch = `refs/pull/${prNumber}/head`;
-            const parameters = {
-                'pr.comment.id': comment.id,
-            };
-            const pipelineId = pipelines[repositoryOwner];
-            if (!pipelineId || pipelineId < 1)
-                throw new Error(`No pipeline set up for org ${repositoryOwner}`);
-            context.log(`Queuing with branch ${sourceBranch} and parameters ${JSON.stringify(parameters)}`);
-            await triggerAzurePipeline(triggerToken, 'gitgitgadget', 'git', pipelineId, sourceBranch, parameters);
+            const run = await triggerWorkflowDispatch(...a, 'handle-pr-comment.yml', 'main', {
+                'pr-comment-url': comment.html_url
+            })
 
             context.res = {
                 // status: 200, /* Defaults to 200 */
-                body: 'Okay!',
+                body: `Okay, triggered ${run.html_url}!`,
             };
         } else {
             context.log(`Unhandled request:\n${JSON.stringify(req, null, 4)}`);

__tests__/index.test.js

@@ -153,17 +153,10 @@ const testIssueComment = (comment, repoOwner, fn) => {
 testIssueComment('/test', async (context) => {
     expect(context.done).toHaveBeenCalledTimes(1)
     expect(context.res).toEqual({
-        body: 'Okay!'
+        body: 'Okay, triggered <the URL to the workflow handle-pr-comment.yml run on main with inputs {"pr-comment-url":"https://github.com/gitgitgadget/git/pull/1886743660"}>!'
     })
-    expect(mockRequest.write).toHaveBeenCalledTimes(1)
-    expect(JSON.parse(mockRequest.write.mock.calls[0][0])).toEqual({
-        definition: {
-            id: 3
-        },
-        sourceBranch: 'refs/pull/1886743660/head',
-        parameters: '{"pr.comment.id":27988538471837300}'
-    })
-    expect(mockRequest.end).toHaveBeenCalledTimes(1)
+    expect(mockRequest.write).not.toHaveBeenCalled()
+    expect(mockRequest.end).not.toHaveBeenCalled()
 })
 
 testIssueComment('/verify-repository', 'nope', (context) => {