Merge pull request #1370 from webstech/lint

maint: update packages and lint issues

Author: dscho

lib/ci-helper.ts

@@ -329,7 +329,7 @@ export class CIHelper {
                 const comment2 = `Found multiple candidates in ${maintainerRepo}:\n${
                     gitsterBranch};\n\nUsing the first one.`;
                 const url2 = await this.github.addPRComment(prKey, comment2);
-                console.log(`Added comment about ${gitsterBranch}: ${url2}`);
+                console.log(`Added comment ${url2.id} about ${gitsterBranch}: ${url2.url}`);
 
                 gitsterBranch = gitsterBranch.substring(0, newline);
             }
@@ -342,7 +342,7 @@ export class CIHelper {
                 notesUpdated = true;
 
                 const url = await this.github.addPRComment(prKey, comment);
-                console.log(`Added comment about ${gitsterBranch}: ${url}`);
+                console.log(`Added comment ${url.id} about ${gitsterBranch}: ${url.url}`);
             }
         }
 
@@ -372,7 +372,7 @@ export class CIHelper {
                 const comment = `This patch series was integrated into ${branch} via https://github.com/${
                     this.config.repo.baseOwner}/${this.config.repo.name}/commit/${mergeCommit}.`;
                 const url = await this.github.addPRComment(prKey, comment);
-                console.log(`Added comment about ${branch}: ${url}`);
+                console.log(`Added comment ${url.id} about ${branch}: ${url.url}`);
             }
         }
 
@@ -527,7 +527,7 @@ GitGitGadget needs an email address to Cc: you on your contribution, so that you
             comment = await this.github.getPRComment(repositoryOwner, commentID);
         } catch (e) {
             if (e instanceof RequestError && e.status === 404 ) {
-                console.log(`Comment ${commentID} not found; doing nothing: '${e.toString()}'`);
+                console.log(`Comment ${commentID} not found; doing nothing:\n'${JSON.stringify(e, null, 2)}'`);
                 return;
             } else {
                 throw e;

lib/github-glue.ts

@@ -314,8 +314,7 @@ export class GitHubGlue {
 
         response.data.map((pr) => {
             if (!pr.user || !pr.base.repo.owner) {
-                throw new Error(`PR ${pr.number} is missing information. ${
-                    pr.toString()}`);
+                throw new Error(`PR ${pr.number} is missing information.\n${JSON.stringify(pr, null, 2)}`);
             }
 
             result.push({
@@ -351,8 +350,8 @@ export class GitHubGlue {
 
         const pullRequest = response.data;
         if (!pullRequest.user) {
-            throw new Error(`PR ${pullRequest.number} is missing information. ${
-                pullRequest.toString()}`);
+            throw new Error(`PR ${pullRequest.number} is missing information.\n${
+                JSON.stringify(pullRequest, null, 2)}`);
         }
 
         return {
@@ -390,8 +389,8 @@ export class GitHubGlue {
         const prNumber = match ? parseInt(match[1], 10) : -1;
 
         if (!response.data.user) {
-            throw new Error(`PR ${prNumber} comment is missing information. ${
-                response.data.toString()}`);
+            throw new Error(`PR ${prNumber} comment is missing information.\n${
+                JSON.stringify(response.data, null, 2)}`);
         }
 
         return {
@@ -418,8 +417,7 @@ export class GitHubGlue {
         const result: IPRCommit[] = [];
         response.data.map((cm) => {
             if (!cm.commit.committer || !cm.commit.author || !cm.sha) {
-                throw new Error(`Commit information missing for PR ${
-                    prNumber} - ${cm.toString()}`);
+                throw new Error(`Commit information missing for PR ${prNumber}:\n${JSON.stringify(cm, null, 2)}`);
             }
 
             const committer = cm.commit.committer;

lib/misc-action.ts

@@ -69,14 +69,15 @@ async function getExternalConfig(file: string): Promise<IConfig> {
 
 function lintConfig(config: IConfig): void {
     if (!config.hasOwnProperty("project")) {
-        throw new Error(`User configurations must have a 'project:'.  Not found in ${path}`);
+        throw new Error(`User configurations must have a 'project:'.  Not found in:\n${
+            JSON.stringify(config, null, 2)}`);
     }
 
     if (!config.repo.owner.match(/^[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}$/i)) {
-        throw new Error(`Invalid 'owner' ${config.repo.owner} in ${path}`);
+        throw new Error(`Invalid 'owner' ${config.repo.owner} in\n${JSON.stringify(config, null, 2)}`);
     }
 
     if (!config.repo.baseOwner.match(/^[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}$/i)) {
-        throw new Error(`Invalid 'baseOwner' ${config.repo.baseOwner} in ${path}`);
+        throw new Error(`Invalid 'baseOwner' ${config.repo.baseOwner} in\n${JSON.stringify(config, null, 2)}`);
     }
 }

lib/pull-action.ts

@@ -61,14 +61,15 @@ async function getExternalConfig(file: string): Promise<IConfig> {
 
 function lintConfig(config: IConfig): void {
     if (!config.hasOwnProperty("project")) {
-        throw new Error(`User configurations must have a 'project:'.  Not found in ${path}`);
+        throw new Error(`User configurations must have a 'project:'.  Not found in\n${
+            JSON.stringify(config, null, 2)}`);
     }
 
     if (!config.repo.owner.match(/^[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}$/i)) {
-        throw new Error(`Invalid 'owner' ${config.repo.owner} in ${path}`);
+        throw new Error(`Invalid 'owner' ${config.repo.owner} in\n${JSON.stringify(config, null, 2)}`);
     }
 
     if (!config.repo.baseOwner.match(/^[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}$/i)) {
-        throw new Error(`Invalid 'baseOwner' ${config.repo.baseOwner} in ${path}`);
+        throw new Error(`Invalid 'baseOwner' ${config.repo.baseOwner} in\n${JSON.stringify(config, null, 2)}`);
     }
 }