Skip to content

Commit f5e3e9e

Browse files
committed
checkasm: Remove unnecessary const on scalar parameters
The ffmpeg coding style doesn't usually use const on scalar parameters (or on the pointer values - as opposed to the type that is pointed to, where it has a semantic meaning), contrary to the dav1d coding style (where this was imported from). This avoids warnings about differences in the type signatures between declaration and definition of this function, with older versions of MSVC. The issue was observed with one version of MSVC 2017, 19.16.27024.1, with warnings like these: src/tests/checkasm/checkasm.c(969): warning C4028: formal parameter 3 different from declaration The warning itself is bogus as the const here is harmless, and newer versions of MSVC no longer warn about this. Signed-off-by: Martin Storsjö <martin@martin.st>
1 parent 8921523 commit f5e3e9e

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/checkasm/checkasm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -933,10 +933,10 @@ void checkasm_report(const char *name, ...)
933933
}
934934

935935
#define DEF_CHECKASM_CHECK_FUNC(type, fmt) \
936-
int checkasm_check_##type(const char *const file, const int line, \
936+
int checkasm_check_##type(const char *file, int line, \
937937
const type *buf1, ptrdiff_t stride1, \
938938
const type *buf2, ptrdiff_t stride2, \
939-
const int w, int h, const char *const name) \
939+
int w, int h, const char *name) \
940940
{ \
941941
int y = 0; \
942942
stride1 /= sizeof(*buf1); \

tests/checkasm/checkasm.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -308,10 +308,10 @@ typedef struct CheckasmPerf {
308308
#endif
309309

310310
#define DECL_CHECKASM_CHECK_FUNC(type) \
311-
int checkasm_check_##type(const char *const file, const int line, \
312-
const type *const buf1, const ptrdiff_t stride1, \
313-
const type *const buf2, const ptrdiff_t stride2, \
314-
const int w, const int h, const char *const name)
311+
int checkasm_check_##type(const char *file, int line, \
312+
const type *buf1, ptrdiff_t stride1, \
313+
const type *buf2, ptrdiff_t stride2, \
314+
int w, int h, const char *name)
315315

316316
DECL_CHECKASM_CHECK_FUNC(uint8_t);
317317
DECL_CHECKASM_CHECK_FUNC(uint16_t);

0 commit comments

Comments
 (0)