chore: enable strict gw group validation

Signed-off-by: Sergei Lukianov <me@slukjanov.name>

Author: Frostman

api/gateway/v1alpha1/gateway_types.go

@@ -7,7 +7,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"log/slog"
 	"net"
 	"net/netip"
 	"regexp"
@@ -387,9 +386,7 @@ func (gw *Gateway) Validate(ctx context.Context, kube kclient.Reader) error {
 		}
 		for _, gwGroup := range gw.Spec.Groups {
 			if !gwGroups[gwGroup.Name] {
-				// TODO enable validation back after it's supplied by the fabricator
-				slog.Warn("Gateway group not found", "gateway", gw.Name, "group", gwGroup.Name)
-				// return fmt.Errorf("gateway group %s not found: %w", gwGroup.Name, ErrInvalidGW)
+				return fmt.Errorf("gateway group %s not found: %w", gwGroup.Name, ErrInvalidGW)
 			}
 		}
 	}

api/gateway/v1alpha1/peering_types.go

@@ -6,14 +6,14 @@ package v1alpha1
 import (
 	"context"
 	"fmt"
-	"log/slog"
 	"maps"
 	"net/netip"
 	"slices"
 	"strconv"
 	"strings"
 	"time"
 
+	kapierrors "k8s.io/apimachinery/pkg/api/errors"
 	kmetav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	kclient "sigs.k8s.io/controller-runtime/pkg/client"
 )
@@ -265,13 +265,11 @@ func (p *Peering) Validate(ctx context.Context, kube kclient.Reader) error {
 	if kube != nil {
 		gwGroup := &GatewayGroup{}
 		if err := kube.Get(ctx, kclient.ObjectKey{Name: p.Spec.GatewayGroup, Namespace: p.Namespace}, gwGroup); err != nil {
-			// TODO enable validation back after it's supplied by the fabricator
-			slog.Warn("Failed to get Gateway group", "name", p.Spec.GatewayGroup, "error", err.Error())
-			// if kapierrors.IsNotFound(err) {
-			// 	return fmt.Errorf("gateway group %s not found", p.Spec.GatewayGroup) //nolint:err113
-			// }
+			if kapierrors.IsNotFound(err) {
+				return fmt.Errorf("gateway group %s not found", p.Spec.GatewayGroup) //nolint:err113
+			}
 
-			// return fmt.Errorf("failed to get gateway group %s: %w", p.Spec.GatewayGroup, err)
+			return fmt.Errorf("failed to get gateway group %s: %w", p.Spec.GatewayGroup, err)
 		}
 	}