fix: add missing prefix to ami cleanur for event rule (#4098)

npalm · web-flow · commit 1ad118bd516c · 2024-08-27T18:10:43.000+02:00
## Problem

Created even rule for ami is static, it missing a dynamic element
(prefix) to ensure unique resources.
diff --git a/modules/ami-housekeeper/main.tf b/modules/ami-housekeeper/main.tf
@@ -100,7 +100,7 @@ resource "aws_iam_role_policy" "ami_housekeeper" {
 }
 
 resource "aws_cloudwatch_event_rule" "ami_housekeeper" {
-  name                = "ami-housekeeper-rule"
+  name                = "${var.prefix}-ami-housekeeper"
   schedule_expression = var.lambda_schedule_expression
   tags                = var.tags
   state               = var.state_event_rule_ami_housekeeper

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ resource "aws_iam_role_policy" "ami_housekeeper" {`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`resource "aws_cloudwatch_event_rule" "ami_housekeeper" {`
`103`		`- name = "ami-housekeeper-rule"`
	`103`	`+ name = "${var.prefix}-ami-housekeeper"`
`104`	`104`	`schedule_expression = var.lambda_schedule_expression`
`105`	`105`	`tags = var.tags`
`106`	`106`	`state = var.state_event_rule_ami_housekeeper`