fix: rename addGhRunnerIdToEC2InstanceTag to tagRunnerId for clarity

stuartp44 · stuartp44 · commit 1baf4afc238e · 2025-07-09T15:36:18.000+02:00
diff --git a/lambdas/functions/control-plane/src/scale-runners/scale-up.ts b/lambdas/functions/control-plane/src/scale-runners/scale-up.ts
@@ -416,7 +416,7 @@ async function createRegistrationTokenConfig(
   }
 }
 
-async function addGhRunnerIdToEC2InstanceTag(instanceId: string, runnerId: string): Promise<void> {
+async function tagRunnerId(instanceId: string, runnerId: string): Promise<void> {
   try {
     await tag(instanceId, [{ Key: 'ghr:github_runner_id', Value: runnerId }]);
   } catch (e) {
@@ -458,7 +458,7 @@ async function createJitConfig(githubRunnerConfig: CreateGitHubRunnerConfig, ins
     metricGitHubAppRateLimit(runnerConfig.headers);
 
     // tag the EC2 instance with the Github runner id
-    await addGhRunnerIdToEC2InstanceTag(instance, runnerConfig.data.runner.id.toString());
+    await tagRunnerId(instance, runnerConfig.data.runner.id.toString());
 
     // store jit config in ssm parameter store
     logger.debug('Runner JIT config for ephemeral runner generated.', {

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ async function createRegistrationTokenConfig(`
`416`	`416`	`}`
`417`	`417`	`}`
`418`	`418`
`419`		`-async function addGhRunnerIdToEC2InstanceTag(instanceId: string, runnerId: string): Promise<void> {`
	`419`	`+async function tagRunnerId(instanceId: string, runnerId: string): Promise<void> {`
`420`	`420`	`try {`
`421`	`421`	`await tag(instanceId, [{ Key: 'ghr:github_runner_id', Value: runnerId }]);`
`422`	`422`	`} catch (e) {`
`@@ -458,7 +458,7 @@ async function createJitConfig(githubRunnerConfig: CreateGitHubRunnerConfig, ins`
`458`	`458`	`metricGitHubAppRateLimit(runnerConfig.headers);`
`459`	`459`
`460`	`460`	`// tag the EC2 instance with the Github runner id`
`461`		`- await addGhRunnerIdToEC2InstanceTag(instance, runnerConfig.data.runner.id.toString());`
	`461`	`+ await tagRunnerId(instance, runnerConfig.data.runner.id.toString());`
`462`	`462`
`463`	`463`	`// store jit config in ssm parameter store`
`464`	`464`	`logger.debug('Runner JIT config for ephemeral runner generated.', {`