refactor: structure of lambda code (#3224)

Author: npalm

.ci/Dockerfile

@@ -1,26 +1,15 @@
 #syntax=docker/dockerfile:1.2
-FROM node:16 as build
-WORKDIR /lambda
+FROM node:18 as build
+WORKDIR /lambdas
 RUN apt-get update \
         && apt-get install -y zip \
         && rm -rf /var/lib/apt/lists/*
 
-FROM build as runner-binaries-syncer
-COPY modules/runner-binaries-syncer/lambdas/runner-binaries-syncer /lambda
-RUN --mount=type=cache,target=/lambda/node_modules,id=runner-binaries-syncer \
-        yarn install && yarn dist
-
-FROM build as runners
-COPY modules/runners/lambdas/runners /lambda
-RUN --mount=type=cache,target=/lambda/node_modules,id=runners \
-        yarn install && yarn dist
-
-FROM build as webhook
-COPY modules/webhook/lambdas/webhook /lambda
-RUN --mount=type=cache,target=/lambda/node_modules,id=webhook \
-        yarn install && yarn dist
+FROM build as lambdas
+COPY lambdas /lambdas
+RUN --mount=type=cache,target=/work/node_modules,id=lambdas \
+        yarn install --frozen-lockfile && yarn dist && \
+        find . -name "*.zip" -exec cp {} . \;
 
 FROM scratch as final
-COPY --from=runner-binaries-syncer /lambda/runner-binaries-syncer.zip /runner-binaries-syncer.zip
-COPY --from=runners                /lambda/runners.zip                /runners.zip
-COPY --from=webhook                /lambda/webhook.zip                /webhook.zip
+COPY --from=lambdas /lambdas/*.zip /

.ci/build-yarn.sh

@@ -1,10 +1,10 @@
-name: Lambda Syncer
+name: Build lambdas
 on:
-  workflow_call:
-    inputs:
-      working-directory:
-        required: true
-        type: string
+  pull_request:
+    branches:
+      - main
+    paths:
+      - 'lambdas/**'
 
 jobs:
   build:
@@ -16,12 +16,12 @@ jobs:
       image: node:${{ matrix.node }}
     defaults:
       run:
-        working-directory: ${{ inputs.working-directory }}/${{ inputs.image }}
+        working-directory: ./lambdas
 
     steps:
       - uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
       - name: Install dependencies
-        run: yarn install
+        run: yarn install --frozen-lockfile
       - name: Run prettier
         run: yarn format-check
       - name: Run linter

.github/workflows/lambda-runner-binaries-syncer.yml

@@ -5,16 +5,14 @@ on:
       - main
       - v1
   workflow_dispatch:
+
 jobs:
-  prepare:
-    name: Create dist
+  release:
+    name: Release
     runs-on: ubuntu-latest
     container: node:18
-    strategy:
-      matrix:
-        lambda: ["modules/webhook/lambdas/webhook", "modules/runner-binaries-syncer/lambdas/runner-binaries-syncer", "modules/runners/lambdas/runners"]
     permissions:
-      contents: read
+      contents: write
       actions: write
     steps:
       - name: Extract lambda name
@@ -26,21 +24,8 @@ jobs:
       - name: Add zip
         run: apt update && apt install zip
       - name: Build dist
-        working-directory: ${{ matrix.lambda }}
+        working-directory: lambdas
         run: yarn install && yarn run test && yarn dist
-      - uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # ratchet:actions/upload-artifact@v3
-        with:
-          name: ${{ steps.lambda.outputs.name }}
-          path: ${{ matrix.lambda }}/${{ steps.lambda.outputs.name }}.zip
-          retention-days: 1
-  release:
-    name: release
-    runs-on: ubuntu-latest
-    needs: prepare
-    outputs:
-      releases_created: ${{ steps.release.outputs.releases_created }}
-      tag_name: ${{ steps.release.outputs.tag_name }}
-    steps:
       - name: Get installation token
         uses: philips-software/app-token-action@a37926571e4cec6f219e06727136efdd073d8657 # ratchet:philips-software/[email protected]
         id: token
@@ -59,23 +44,11 @@ jobs:
           default-branch: ${{ steps.branch.outputs.name }}
           release-type: terraform-module
           token: ${{ steps.token.outputs.token }}
-  assets:
-    name: upload assets
-    if: ${{ needs.release.outputs.releases_created }}
-    needs: release
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        asset: ["webhook", "runner-binaries-syncer", "runners"]
-    permissions:
-      contents: write
-      actions: read
-    steps:
-      - uses: actions/checkout@24cb9080177205b6e8c946b17badbe402adc938f # ratchet:actions/checkout@v3
-      - uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # ratchet:actions/download-artifact@v3
-        with:
-          name: ${{ matrix.asset }}
       - name: Upload Release Asset
+        if: ${{ steps.release.outputs.releases_created }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: gh release upload ${{ needs.release.outputs.tag_name }} ${{ matrix.asset }}.zip
+        run: |
+          for f in $(find . -name '*.zip'); do
+            gh release upload ${{ needs.release.outputs.tag_name }} $f
+          done

.github/workflows/lambda-runners.yml

@@ -27,9 +27,9 @@ jobs:
         uses: actions/checkout@v3
       - name: "Fake zip files" # Validate will fail if it cannot find the zip files
         run: |
-          touch modules/webhook/lambdas/webhook/webhook.zip
-          touch modules/runners/lambdas/runners/runners.zip
-          touch modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/runner-binaries-syncer.zip
+          touch lambdas/functions/webhook/webhook.zip
+          touch lambdas/functions/control-plane/runners.zip
+          touch lambdas/functions/gh-agent-syncer/runner-binaries-syncer.zip
       - name: terraform init
         run: terraform init -get -backend=false -input=false
       - if: contains(matrix.terraform, '1.3.')

.github/workflows/lambda-webhook.yml

@@ -1,7 +1 @@
-{
-    "sonarlint.rules": {
-        "javascript:S4123": {
-            "level": "off"
-        }
-    }
-}
+{}