Skip to content

Commit e8007e9

Browse files
authored
chor: fix various typos (#77)
1 parent 81abfd4 commit e8007e9

File tree

14 files changed

+34
-34
lines changed

14 files changed

+34
-34
lines changed

.ci/build.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#!/usr/bin/env bash
22

3-
lambaSrcDirs=("modules/runner-binaries-syncer/lambdas/runner-binaries-syncer" "modules/runners/lambdas/scale-runners" "modules/webhook/lambdas/webhook")
3+
lambdaSrcDirs=("modules/runner-binaries-syncer/lambdas/runner-binaries-syncer" "modules/runners/lambdas/scale-runners" "modules/webhook/lambdas/webhook")
44
repoRoot=$(dirname "${BASH_SOURCE[0]}")/..
55

6-
for lambdaDir in ${lambaSrcDirs[@]}; do
6+
for lambdaDir in ${lambdaSrcDirs[@]}; do
77
cd $repoRoot/${lambdaDir}
88
docker build -t lambda -f ../../../../.ci/Dockerfile .
99
docker create --name lambda lambda

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,30 +243,30 @@ No requirements.
243243
| enable\_organization\_runners | n/a | `bool` | n/a | yes |
244244
| encrypt\_secrets | Encrypt secret variables for lambda's such as secrets and private keys. | `bool` | `true` | no |
245245
| environment | A name that identifies the environment, used as prefix and for tagging. | `string` | n/a | yes |
246-
| github\_app | GitHub app parameters, see your github aapp. Ensure the key is base64 encoded. | <pre>object({<br> key_base64 = string<br> id = string<br> client_id = string<br> client_secret = string<br> webhook_secret = string<br> })</pre> | n/a | yes |
246+
| github\_app | GitHub app parameters, see your github app. Ensure the key is base64 encoded. | <pre>object({<br> key_base64 = string<br> id = string<br> client_id = string<br> client_secret = string<br> webhook_secret = string<br> })</pre> | n/a | yes |
247247
| instance\_profile\_path | The path that will be added to the instance\_profile, if not set the environment name will be used. | `string` | `null` | no |
248248
| instance\_type | Instance type for the action runner. | `string` | `"m5.large"` | no |
249249
| kms\_key\_id | Custom KMS key to encrypted lambda secrets, if not provided and `encrypt_secrets` = `true` a KMS key will be created by the module. Secrets will be encrypted with a context `Environment = var.environment`. | `string` | `null` | no |
250250
| manage\_kms\_key | Let the module manage the KMS key. | `bool` | `true` | no |
251-
| minimum\_running\_time\_in\_minutes | The time an ec2 action runner should be running at minium before terminated if non busy. | `number` | `5` | no |
251+
| minimum\_running\_time\_in\_minutes | The time an ec2 action runner should be running at minimum before terminated if non busy. | `number` | `5` | no |
252252
| role\_path | The path that will be added to role path for created roles, if not set the environment name will be used. | `string` | `null` | no |
253253
| role\_permissions\_boundary | Permissions boundary that will be added to the created roles. | `string` | `null` | no |
254254
| runner\_as\_root | Run the action runner under the root user. | `bool` | `false` | no |
255255
| runner\_binaries\_syncer\_lambda\_timeout | Time out of the binaries sync lambda in seconds. | `number` | `300` | no |
256256
| runner\_binaries\_syncer\_lambda\_zip | File location of the binaries sync lambda zip file. | `string` | `null` | no |
257257
| runner\_extra\_labels | Extra labels for the runners (GitHub). Separate each label by a comma | `string` | `""` | no |
258258
| runners\_lambda\_zip | File location of the lambda zip file for scaling runners. | `string` | `null` | no |
259-
| runners\_maximum\_count | The maximum number of runners tha will be created. | `number` | `3` | no |
260-
| runners\_scale\_down\_lambda\_timeout | Time out for the scale down lambda in seconds. | `number` | `60` | no |
261-
| runners\_scale\_up\_lambda\_timeout | Time out for the scale up lambda in seconds. | `number` | `60` | no |
259+
| runners\_maximum\_count | The maximum number of runners that will be created. | `number` | `3` | no |
260+
| runners\_scale\_down\_lambda\_timeout | Time out for the scale up lambda in seconds. | `number` | `60` | no |
261+
| runners\_scale\_up\_lambda\_timeout | Time out for the scale down lambda in seconds. | `number` | `60` | no |
262262
| scale\_down\_schedule\_expression | Scheduler expression to check every x for scale down. | `string` | `"cron(*/5 * * * ? *)"` | no |
263263
| subnet\_ids | List of subnets in which the action runners will be launched, the subnets needs to be subnets in the `vpc_id`. | `list(string)` | n/a | yes |
264264
| tags | Map of tags that will be added to created resources. By default resources will be tagged with name and environment. | `map(string)` | `{}` | no |
265265
| userdata\_post\_install | Script to be ran after the GitHub Actions runner is installed on the EC2 instances | `string` | `""` | no |
266266
| userdata\_pre\_install | Script to be ran before the GitHub Actions runner is installed on the EC2 instances | `string` | `""` | no |
267267
| vpc\_id | The VPC for security groups of the action runners. | `string` | n/a | yes |
268268
| webhook\_lambda\_timeout | Time out of the webhook lambda in seconds. | `number` | `10` | no |
269-
| webhook\_lambda\_zip | File location of the wehbook lambda zip file. | `string` | `null` | no |
269+
| webhook\_lambda\_zip | File location of the webhook lambda zip file. | `string` | `null` | no |
270270

271271
## Outputs
272272

examples/default/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This modules shows how to create GitHub action runners. Lambda release will be d
44

55
## Usages
66

7-
Steps for the full setup, such as creating a GitHub app can be found in the root module's [README](../../README.md). First download the Lambda releases from GitHub. Alternatively you can build the lamdas locally with Node or Docker, there is a simple build script in `<root>/.ci/build.sh`. In the `main.tf` you can simple remove the location of the lambda zip files, the default location will work in this case.
7+
Steps for the full setup, such as creating a GitHub app can be found in the root module's [README](../../README.md). First download the Lambda releases from GitHub. Alternatively you can build the lambdas locally with Node or Docker, there is a simple build script in `<root>/.ci/build.sh`. In the `main.tf` you can simple remove the location of the lambda zip files, the default location will work in this case.
88

99
```bash
1010
cd lambdas-download

examples/default/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ module "runners" {
3333
enable_organization_runners = false
3434
runner_extra_labels = "default,example"
3535

36-
# disable KMS and ecnryption
36+
# disable KMS and encryption
3737
# encrypt_secrets = false
3838
}

examples/permissions-boundary/setup/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module "iam" {
77
account_id = data.aws_caller_identity.current.account_id
88

99
namespaces = {
10-
boundary_namespace = "bounaries"
10+
boundary_namespace = "boundaries"
1111
role_namespace = "runners"
1212
policy_namespace = "runners"
1313
instance_profile_namespace = "runners"

modules/runner-binaries-syncer/runner-binaries-syncer.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ data "aws_iam_policy_document" "lambda_assume_role_policy" {
4343
}
4444

4545
resource "aws_iam_role_policy" "lambda_logging" {
46-
name = "${var.environment}-lamda-logging-policy-syncer"
46+
name = "${var.environment}-lambda-logging-policy-syncer"
4747
role = aws_iam_role.syncer_lambda.id
4848

4949
policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", {})
5050
}
5151

5252
resource "aws_iam_role_policy" "syncer" {
53-
name = "${var.environment}-lamda-syncer-s3-policy"
53+
name = "${var.environment}-lambda-syncer-s3-policy"
5454
role = aws_iam_role.syncer_lambda.id
5555

5656
policy = templatefile("${path.module}/policies/lambda-syncer.json", {

modules/runners/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,22 +67,22 @@ No requirements.
6767
| aws\_region | AWS region. | `string` | n/a | yes |
6868
| block\_device\_mappings | The EC2 instance block device configuration. Takes the following keys: `delete_on_termination`, `volume_type`, `volume_size`, `encrypted`, `iops` | `map(string)` | `{}` | no |
6969
| enable\_organization\_runners | n/a | `bool` | n/a | yes |
70-
| encryption | KMS key to encrypted lambda environment secrets. Either provide a key and `ecnrypt` set to `true`. Or set the key to `null` and encrypt to `false`. | <pre>object({<br> kms_key_id = string<br> encrypt = bool<br> })</pre> | n/a | yes |
70+
| encryption | KMS key to encrypted lambda environment secrets. Either provide a key and `encrypt` set to `true`. Or set the key to `null` and encrypt to `false`. | <pre>object({<br> kms_key_id = string<br> encrypt = bool<br> })</pre> | n/a | yes |
7171
| environment | A name that identifies the environment, used as prefix and for tagging. | `string` | n/a | yes |
72-
| github\_app | GitHub app parameters, see your github aapp. Ensure the key is base64 encoded. | <pre>object({<br> key_base64 = string<br> id = string<br> client_id = string<br> client_secret = string<br> })</pre> | n/a | yes |
72+
| github\_app | GitHub app parameters, see your github app. Ensure the key is base64 encoded. | <pre>object({<br> key_base64 = string<br> id = string<br> client_id = string<br> client_secret = string<br> })</pre> | n/a | yes |
7373
| instance\_profile\_path | The path that will be added to the instance\_profile, if not set the environment name will be used. | `string` | `null` | no |
7474
| instance\_type | Default instance type for the action runner. | `string` | `"m5.large"` | no |
7575
| lambda\_timeout\_scale\_down | Time out for the scale down lambda in seconds. | `number` | `60` | no |
7676
| lambda\_timeout\_scale\_up | Time out for the scale up lambda in seconds. | `number` | `60` | no |
7777
| lambda\_zip | File location of the lambda zip file. | `string` | `null` | no |
7878
| market\_options | Market options for the action runner instances. | `string` | `"spot"` | no |
79-
| minimum\_running\_time\_in\_minutes | The time an ec2 action runner should be running at minium before terminated if non busy. | `number` | `5` | no |
80-
| overrides | This maps provides the possibility to override some defaults. The following attributes are supported: `name_sg` overwrite the `Name` tag for all security groups created by this module. `name_runner_agent_instance` override the `Name` tag for the ec2 instance defined in the auto launch configuration. `name_docker_machine_runners` ovverrid the `Name` tag spot instances created by the runner agent. | `map(string)` | <pre>{<br> "name_runner": "",<br> "name_sg": ""<br>}</pre> | no |
79+
| minimum\_running\_time\_in\_minutes | The time an ec2 action runner should be running at minimum before terminated if non busy. | `number` | `5` | no |
80+
| overrides | This maps provides the possibility to override some defaults. The following attributes are supported: `name_sg` overwrite the `Name` tag for all security groups created by this module. `name_runner_agent_instance` override the `Name` tag for the ec2 instance defined in the auto launch configuration. `name_docker_machine_runners` override the `Name` tag spot instances created by the runner agent. | `map(string)` | <pre>{<br> "name_runner": "",<br> "name_sg": ""<br>}</pre> | no |
8181
| role\_path | The path that will be added to the role, if not set the environment name will be used. | `string` | `null` | no |
8282
| role\_permissions\_boundary | Permissions boundary that will be added to the created role for the lambda. | `string` | `null` | no |
8383
| runner\_as\_root | Run the action runner under the root user. | `bool` | `false` | no |
8484
| runner\_extra\_labels | Extra labels for the runners (GitHub). Separate each label by a comma | `string` | `""` | no |
85-
| runners\_maximum\_count | The maximum number of runners tha will be created. | `number` | `3` | no |
85+
| runners\_maximum\_count | The maximum number of runners that will be created. | `number` | `3` | no |
8686
| s3\_bucket\_runner\_binaries | n/a | <pre>object({<br> arn = string<br> })</pre> | n/a | yes |
8787
| s3\_location\_runner\_binaries | S3 location of runner distribution. | `string` | n/a | yes |
8888
| scale\_down\_schedule\_expression | Scheduler expression to check every x for scale down. | `string` | `"cron(*/5 * * * ? *)"` | no |
@@ -91,7 +91,7 @@ No requirements.
9191
| tags | Map of tags that will be added to created resources. By default resources will be tagged with name and environment. | `map(string)` | `{}` | no |
9292
| userdata\_post\_install | User-data script snippet to insert after GitHub acton runner install | `string` | `""` | no |
9393
| userdata\_pre\_install | User-data script snippet to insert before GitHub acton runner install | `string` | `""` | no |
94-
| vpc\_id | The VPC for the security groupss. | `string` | n/a | yes |
94+
| vpc\_id | The VPC for the security groups. | `string` | n/a | yes |
9595

9696
## Outputs
9797

modules/runners/variables.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ variable "aws_region" {
44
}
55

66
variable "vpc_id" {
7-
description = "The VPC for the security groupss."
7+
description = "The VPC for the security groups."
88
type = string
99
}
1010

@@ -14,7 +14,7 @@ variable "subnet_ids" {
1414
}
1515

1616
variable "overrides" {
17-
description = "This maps provides the possibility to override some defaults. The following attributes are supported: `name_sg` overwrite the `Name` tag for all security groups created by this module. `name_runner_agent_instance` override the `Name` tag for the ec2 instance defined in the auto launch configuration. `name_docker_machine_runners` ovverrid the `Name` tag spot instances created by the runner agent."
17+
description = "This maps provides the possibility to override some defaults. The following attributes are supported: `name_sg` overwrite the `Name` tag for all security groups created by this module. `name_runner_agent_instance` override the `Name` tag for the ec2 instance defined in the auto launch configuration. `name_docker_machine_runners` override the `Name` tag spot instances created by the runner agent."
1818
type = map(string)
1919

2020
default = {
@@ -102,7 +102,7 @@ variable "enable_organization_runners" {
102102
}
103103

104104
variable "github_app" {
105-
description = "GitHub app parameters, see your github aapp. Ensure the key is base64 encoded."
105+
description = "GitHub app parameters, see your github app. Ensure the key is base64 encoded."
106106
type = object({
107107
key_base64 = string
108108
id = string
@@ -118,7 +118,7 @@ variable "scale_down_schedule_expression" {
118118
}
119119

120120
variable "minimum_running_time_in_minutes" {
121-
description = "The time an ec2 action runner should be running at minium before terminated if non busy."
121+
description = "The time an ec2 action runner should be running at minimum before terminated if non busy."
122122
type = number
123123
default = 5
124124
}
@@ -178,7 +178,7 @@ variable "runners_maximum_count" {
178178
}
179179

180180
variable "encryption" {
181-
description = "KMS key to encrypted lambda environment secrets. Either provide a key and `ecnrypt` set to `true`. Or set the key to `null` and encrypt to `false`."
181+
description = "KMS key to encrypted lambda environment secrets. Either provide a key and `encrypt` set to `true`. Or set the key to `null` and encrypt to `false`."
182182
type = object({
183183
kms_key_id = string
184184
encrypt = bool

modules/setup-iam-permissions/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ No requirements.
5151

5252
| Name | Description | Type | Default | Required |
5353
|------|-------------|------|---------|:--------:|
54-
| account\_id | The module allows to switch to te crateed role from the provided account id. | `string` | n/a | yes |
54+
| account\_id | The module allows to switch to the created role from the provided account id. | `string` | n/a | yes |
5555
| environment | A name that identifies the environment, used as prefix and for tagging. | `string` | n/a | yes |
56-
| namespaces | The role will be only allowed to crated rolo, policies and instance profiles in the gevin namespace / path. All policies in the boundaries namespace cannot be modified by this role. | <pre>object({<br> boundary_namespace = string<br> role_namespace = string<br> policy_namespace = string<br> instance_profile_namespace = string<br> })</pre> | n/a | yes |
56+
| namespaces | The role will be only allowed to create roles, policies and instance profiles in the given namespace / path. All policies in the boundaries namespace cannot be modified by this role. | <pre>object({<br> boundary_namespace = string<br> role_namespace = string<br> policy_namespace = string<br> instance_profile_namespace = string<br> })</pre> | n/a | yes |
5757

5858
## Outputs
5959

modules/setup-iam-permissions/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ variable "environment" {
44
}
55

66
variable "namespaces" {
7-
description = "The role will be only allowed to crated rolo, policies and instance profiles in the gevin namespace / path. All policies in the boundaries namespace cannot be modified by this role."
7+
description = "The role will be only allowed to create roles, policies and instance profiles in the given namespace / path. All policies in the boundaries namespace cannot be modified by this role."
88
type = object({
99
boundary_namespace = string
1010
role_namespace = string
@@ -14,7 +14,7 @@ variable "namespaces" {
1414
}
1515

1616
variable "account_id" {
17-
description = "The module allows to switch to te crateed role from the provided account id."
17+
description = "The module allows to switch to the created role from the provided account id."
1818
type = string
1919

2020
}

0 commit comments

Comments
 (0)