chore(ci): drop lerna for nx (#3769)

npalm · nadavsinai-philips · web-flow · commit ea392aebe263 · 2024-02-20T10:10:47.000+01:00
Replacing Lerna by NX
- allow to cache parts of the build (local runs)

---------

Co-authored-by: Nadav Sinai &lt;nadav.sinai@philips.com&gt;
diff --git a/.vscode/gh-runners.code-workspace b/.vscode/gh-runners.code-workspace
@@ -5,28 +5,8 @@
       "path": ".."
     },
     {
-      "name": "🚀 @lambda/functions/ami-housekeeper",
-      "path": "../lambdas/functions/ami-housekeeper"
-    },
-    {
-      "name": "🚀 @lambda/functions/control-plane",
-      "path": "../lambdas/functions/control-plane"
-    },
-    {
-      "name": "🚀 @lambda/functions/gh-agent-syncer",
-      "path": "../lambdas/functions/gh-agent-syncer"
-    },
-    {
-      "name": "🚀 @lambda/functions/webhook",
-      "path": "../lambdas/functions/webhook"
-    },
-    {
-      "name": "📦 @lambda/libs/aws-ssm-util",
-      "path": "../lambdas/libs/aws-ssm-util"
-    },
-    {
-      "name": "📦 @lambdas/libs/aws-powertools-util",
-      "path": "../lambdas/libs/aws-powertools-util"
+      "name": "🚀 lambdas",
+      "path": "../lambdas"
     }
   ],
   "settings": {
diff --git a/lambdas/.gitignore b/lambdas/.gitignore
@@ -6,3 +6,6 @@ dist/
 # Ignore all yarn.lock files except the one in the root
 **/yarn.lock
 !/yarn.lock
+
+
+.nx/cache
diff --git a/lambdas/.nvmrc b/lambdas/.nvmrc
@@ -1 +1 @@
-v18
+v20
diff --git a/lambdas/.prettierignore b/lambdas/.prettierignore
@@ -0,0 +1,4 @@
+# Add files here to ignore them from prettier formatting
+/dist
+/coverage
+/.nx/cache
diff --git a/lambdas/functions/ami-housekeeper/package.json b/lambdas/functions/ami-housekeeper/package.json
@@ -5,8 +5,8 @@
   "license": "MIT",
   "scripts": {
     "start": "ts-node-dev src/local.ts",
-    "test": "NODE_ENV=test jest",
-    "test:watch": "NODE_ENV=test jest --watch",
+    "test": "NODE_ENV=test nx test",
+    "test:watch": "NODE_ENV=test nx test --watch",
     "lint": "yarn eslint src",
     "watch": "ts-node-dev --respawn --exit-child src/local.ts",
     "build": "ncc build src/lambda.ts -o dist",
@@ -44,5 +44,8 @@
     "@terraform-aws-github-runner/aws-ssm-util": "*",
     "cron-parser": "^4.8.1",
     "typescript": "^5.3.3"
+  },
+  "nx": {
+    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
   }
 }
diff --git a/lambdas/functions/control-plane/package.json b/lambdas/functions/control-plane/package.json
@@ -5,8 +5,8 @@
   "license": "MIT",
   "scripts": {
     "start": "ts-node-dev src/local.ts",
-    "test": "NODE_ENV=test jest",
-    "test:watch": "NODE_ENV=test jest --watch",
+    "test": "NODE_ENV=test nx test",
+    "test:watch": "NODE_ENV=test nx test --watch",
     "lint": "yarn eslint src",
     "watch": "ts-node-dev --respawn --exit-child src/local-ssm-housekeeper.ts",
     "build": "ncc build src/lambda.ts -o dist",
@@ -49,5 +49,8 @@
     "axios": "^1.6.2",
     "cron-parser": "^4.8.1",
     "typescript": "^5.3.3"
+  },
+  "nx": {
+    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
   }
 }
diff --git a/lambdas/functions/gh-agent-syncer/package.json b/lambdas/functions/gh-agent-syncer/package.json
@@ -5,8 +5,8 @@
   "license": "MIT",
   "scripts": {
     "start": "ts-node-dev src/local.ts",
-    "test": "NODE_ENV=test jest",
-    "test:watch": "NODE_ENV=test jest --watch",
+    "test": "NODE_ENV=test nx test",
+    "test:watch": "NODE_ENV=test nx test --watch",
     "lint": "yarn eslint src",
     "watch": "ts-node-dev --respawn --exit-child src/local.ts",
     "build": "ncc build src/lambda.ts -o dist",
@@ -43,5 +43,8 @@
     "@middy/core": "^4.7.0",
     "@terraform-aws-github-runner/aws-powertools-util": "*",
     "axios": "^1.6.2"
+  },
+  "nx": {
+    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
   }
 }
diff --git a/lambdas/functions/webhook/package.json b/lambdas/functions/webhook/package.json
@@ -1,12 +1,12 @@
 {
-  "name": "@terraform-aws-github-runner/function-webhook",
+  "name": "@terraform-aws-github-runner/webhook",
   "version": "1.0.0",
   "main": "lambda.ts",
   "license": "MIT",
   "scripts": {
     "start": "ts-node-dev src/local.ts",
-    "test": "NODE_ENV=test jest",
-    "test:watch": "NODE_ENV=test jest --watch",
+    "test": "NODE_ENV=test nx test",
+    "test:watch": "NODE_ENV=test nx test --watch",
     "lint": "yarn eslint src",
     "watch": "ts-node-dev --respawn --exit-child src/local.ts",
     "build": "ncc build src/lambda.ts -o dist",
@@ -46,5 +46,8 @@
     "@terraform-aws-github-runner/aws-powertools-util": "*",
     "@terraform-aws-github-runner/aws-ssm-util": "*",
     "aws-lambda": "^1.0.7"
+  },
+  "nx": {
+    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
   }
 }
diff --git a/lambdas/lerna.json b/lambdas/lerna.json
diff --git a/lambdas/libs/aws-powertools-util/package.json b/lambdas/libs/aws-powertools-util/package.json
@@ -5,8 +5,8 @@
   "license": "MIT",
   "scripts": {
     "start": "ts-node-dev src/local.ts",
-    "test": "NODE_ENV=test jest",
-    "test:watch": "NODE_ENV=test jest --watch",
+    "test": "NODE_ENV=test nx test",
+    "test:watch": "NODE_ENV=test nx test --watch",
     "lint": "yarn eslint src",
     "watch": "ts-node-dev --respawn --exit-child src/local.ts",
     "format": "prettier --write \"**/*.ts\"",
@@ -39,5 +39,8 @@
     "@aws-lambda-powertools/logger": "^1.17.0",
     "@aws-lambda-powertools/tracer": "^1.14.0",
     "aws-lambda": "^1.0.7"
+  },
+  "nx": {
+    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
   }
 }
diff --git a/lambdas/libs/aws-ssm-util/package.json b/lambdas/libs/aws-ssm-util/package.json
@@ -5,8 +5,8 @@
   "license": "MIT",
   "scripts": {
     "start": "ts-node-dev src/local.ts",
-    "test": "NODE_ENV=test jest",
-    "test:watch": "NODE_ENV=test jest --watch",
+    "test": "NODE_ENV=test nx test",
+    "test:watch": "NODE_ENV=test nx test --watch",
     "lint": "yarn eslint src",
     "watch": "ts-node-dev --respawn --exit-child src/local.ts",
     "format": "prettier --write \"**/*.ts\"",
@@ -39,5 +39,8 @@
     "@aws-sdk/client-ssm": "^3.477.0",
     "@aws-sdk/types": "^3.433.0",
     "@terraform-aws-github-runner/aws-powertools-util": "*"
+  },
+  "nx": {
+    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
   }
 }
diff --git a/lambdas/nx.json b/lambdas/nx.json
@@ -0,0 +1,40 @@
+{
+  "$schema": "./node_modules/nx/schemas/nx-schema.json",
+  "affected": {
+    "defaultBase": "main"
+  },
+  "workspaceLayout": {
+    "libsDir": "libs",
+    "appsDir": "functions"
+  },
+  "plugins": [
+
+    {
+      "plugin": "@nx/jest/plugin",
+      "options": {
+        "targetName": "test"
+      }
+    },
+    {
+      "plugin": "@nx/eslint/plugin",
+      "options": {
+        "targetName": "lint"
+      }
+    }
+  ],
+"targetDefaults": {
+  "build": {
+    "inputs": ["{projectRoot}/src/index.ts"],
+    "dependsOn": ["default", "^default","^build"],
+    "executor": "@nx/workspace:run-commands",
+    "cache": true
+  },
+  "dist":{
+    "outputs": ["{projectRoot}/dist/**/*"],
+    "dependsOn": ["build"],
+    "executor": "@nx/workspace:run-commands",
+    "cache": true
+  }
+}
+
+}
diff --git a/lambdas/package.json b/lambdas/package.json
@@ -6,18 +6,29 @@
     "libs/*"
   ],
   "scripts": {
-    "bootstrap": "lerna bootstrap",
-    "build": "lerna run build",
-    "dist": "lerna run build && lerna run dist",
-    "format": "lerna run format",
-    "format-check": "lerna run format-check",
-    "lint": "lerna run lint",
-    "test": "lerna run test"
-  },
-  "devDependencies": {
-    "lerna": "^8.0.1"
+    "build": "nx run-many --target=build --all",
+    "affected:build": "nx affected:build --parallel",
+    "dist": "nx run-many --target=dist --all",
+    "format": "nx run-many --target=format --all",
+    "format-check": "nx run-many --target=format-check --all",
+    "affected:format-check": "nx affected:format-check --parallel",
+    "lint": "nx run-many --target=lint --all",
+    "affected:lint": "nx affected:lint --parallel",
+    "test": "nx run-many --target=test --all",
+    "affected:test": "nx affected:test --parallel"
   },
   "resolutions": {
     "@octokit/types": "^12.0.0"
+  },
+  "devDependencies": {
+    "@nx/eslint": "18.0.4",
+    "@nx/jest": "18.0.4",
+    "@nx/js": "^18.0.4",
+    "@swc-node/register": "~1.8.0",
+    "@swc/core": "~1.3.85",
+    "@swc/helpers": "~0.5.2",
+    "jest": "^29.4.1",
+    "nx": "18.0.4",
+    "prettier": "^2.6.2"
   }
 }
diff --git a/lambdas/yarn.lock b/lambdas/yarn.lock
