Scale-up lambda fails with error - HttpError: Integration not found in ghe.com

[neethu-p]

Hello Team,

I am attempting to implement the multi-runner module in a our GitHub Enterprise Cloud with data residency instance hosted on companyname.ghe.com. With this data residency feature of Github, the API URL has changed from api.github.com to api.companyname.ghe.com.

In this case the creatAuthAppfunction in scale-up.ts fails, as the API endpoint is not set .Hence the scale-up lambda function is failing with the following error: "message": "Ignoring error: HttpError: Integration not found - https://docs.github.com/rest. `Could you confirm if this module is currently supported in the GitHub with ghe.com domain?

It works fine in our in Enterprise and public Cloud GH instances.

[npalm]

I have no option to test the module on ghe.com. The module should work on GHES, but also that version I cannot test. You could try to configure the module with GHES. If I am coorect you can set the API endpoint in that case.

Would be great to get people on this OS module that can support and test those cases.

[neethu-p]

In GHES the API endpoint is ghesUrl/api/v3, which works as expected. But in our case the API endpoint is https://api.companyname.ghe.com, for which I don't see any option to set the api url.
I can try to open up a PR with supporting changes

[npalm]

Had a quick look in the code, but maybe you can just pass the url in the ghes parameter:

terraform-aws-github-runner/lambdas/functions/control-plane/src/github/auth.ts

Lines 20 to 28 in 6a4a0e0

	export async function createOctokitClient(token: string, ghesApiUrl = ''): Promise<Octokit> {
	const CustomOctokit = Octokit.plugin(throttling);
	const ocktokitOptions: OctokitOptions = {
	auth: token,
	};
	if (ghesApiUrl) {
	ocktokitOptions.baseUrl = ghesApiUrl;
	ocktokitOptions.previews = ['antiope'];
	}

[neethu-p]

I think the ghesApiUrl is derived from the ghes-url param here -

terraform-aws-github-runner/lambdas/functions/control-plane/src/scale-runners/scale-up.ts

Line 354 in 6a4a0e0

export function getGitHubEnterpriseApiUrl() {

[npalm]

Yes I think you are right, so it is hard-coded :( (partially).

I think it would be better to make it in the lambda more generic. In case we could get it backwards compatible via terraform that would be nice. But would certainly avoid having more cased in the code, should work if we just inject the full url. Would be great if uyou can propose a PR.

You can run a quick test, by just chainging the the Lambda code (even hardcoded). And run yarn install && yarn dist to build packages. Just to quickly test if that is the only change you need.

[neethu-p]

Hello, I have raised a PR with changes here - #4367. Please have a look

[npalm]

@neethu-p reverted your PR due to failing CI, see links in the PR and revert PR.

[neethu-p]

A new PR is opened up to address CI issue. - #4390

[neethu-p]

The build is fixed in the new PR. Please have a look:)