code review comments

Author: karpikpl

shared/utils/metrics-util.ts

@@ -12,7 +12,6 @@ const cache = new Map<string, CacheData>();
 interface CacheData {
   data: CopilotMetrics[];
   valid_until: number;
-  auth_fingerprint: string; // hashed representation of Authorization header used to populate cache
 }
 
 class MetricsError extends Error {
@@ -112,7 +111,7 @@ export async function getMetricsData(event: H3Event<EventHandlerRequest>): Promi
   // Attempt cache lookup with auth fingerprint validation
   const cachedData = cache.get(cacheKey);
   if (cachedData) {
-    if (cachedData.valid_until > Date.now() / 1000 && cachedData.auth_fingerprint === cacheKey.split(':')[0]) {
+    if (cachedData.valid_until > Date.now() / 1000) {
       logger.info(`Returning cached data for ${cacheKey}`);
       return cachedData.data;
     } else {
@@ -134,8 +133,7 @@ export async function getMetricsData(event: H3Event<EventHandlerRequest>): Promi
     const filteredUsageData = filterHolidaysFromMetrics(usageData, options.excludeHolidays || false, options.locale);
     // metrics is the old API format
     const validUntil = Math.floor(Date.now() / 1000) + 5 * 60; // Cache for 5 minutes
-  const authFingerprint: string = cacheKey.split(':', 1)[0] || '';
-  cache.set(cacheKey, { data: filteredUsageData, valid_until: validUntil, auth_fingerprint: authFingerprint });
+  cache.set(cacheKey, { data: filteredUsageData, valid_until: validUntil });
     return filteredUsageData;
   } catch (error: unknown) {
     logger.error('Error fetching metrics data:', error);

tests/test.setup.ts

@@ -0,0 +1,31 @@
+// Global test setup
+// Force mock mode so server-side handlers use local mock data instead of hitting GitHub APIs.
+process.env.NUXT_PUBLIC_IS_DATA_MOCKED = 'true';
+
+// Block accidental real GitHub API calls if mock mode logic fails.
+const originalFetch: typeof globalThis.fetch | undefined = globalThis.fetch;
+if (originalFetch) {
+  globalThis.fetch = (async (...args: Parameters<typeof fetch>): Promise<Response> => {
+    const url = String(args[0]);
+    if (url.startsWith('https://api.github.com')) {
+      throw new Error(`Blocked external GitHub API call during tests: ${url}`);
+    }
+    return originalFetch(...args);
+  }) as typeof fetch;
+}
+
+// Stub $fetch (ofetch) similarly if present at runtime.
+if (typeof globalThis.$fetch === 'function') {
+  const original$fetch = globalThis.$fetch;
+  const wrapped: typeof globalThis.$fetch = ((url: unknown, opts: unknown) => {
+    const str = String(url);
+    if (str.startsWith('https://api.github.com')) {
+      return Promise.reject(new Error(`Blocked external GitHub API call during tests via $fetch: ${str}`));
+    }
+    return original$fetch(url as never, opts as never);
+  }) as typeof globalThis.$fetch;
+  // Preserve special properties if present
+  (wrapped as unknown as { raw?: unknown }).raw = (original$fetch as unknown as { raw?: () => unknown }).raw?.bind(original$fetch);
+  (wrapped as unknown as { create?: unknown }).create = (original$fetch as unknown as { create?: () => unknown }).create?.bind(original$fetch);
+  globalThis.$fetch = wrapped;
+}

vitest.config.ts

@@ -5,6 +5,7 @@ export default defineVitestConfig({
   test: {
     exclude: ['**/node_modules/**', '**/e2e-tests/**'],
     environment: 'nuxt',
-    globals: true // Use describe, test/expect, etc. without importing
+  globals: true, // Use describe, test/expect, etc. without importing
+  setupFiles: ['./tests/test.setup.ts']
   }
 })