Skip to content

Commit fb4e70f

Browse files
committed
refactor: Update acceptance rate calculation in MetricsViewer.vue
1 parent ea11d05 commit fb4e70f

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/components/MetricsViewer.vue

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,11 +252,9 @@ export default defineComponent({
252252
}
253253
]
254254
};
255-
256-
let sum = 0;
255+
257256
const acceptanceRates = data.map((m: Metrics) => {
258257
const rate = m.total_lines_suggested !== 0 ? (m.total_lines_accepted / m.total_lines_suggested) * 100 : 0;
259-
sum += rate;
260258
return rate;
261259
});
262260
@@ -274,8 +272,12 @@ export default defineComponent({
274272
}
275273
]
276274
};
277-
278-
acceptanceRateAverage.value = cumulativeNumberAcceptances.value / cumulativeNumberSuggestions.value * 100;
275+
276+
if(cumulativeNumberSuggestions.value === 0){
277+
acceptanceRateAverage.value = 0;
278+
} else {
279+
acceptanceRateAverage.value = cumulativeNumberAcceptances.value / cumulativeNumberSuggestions.value * 100;
280+
}
279281
280282
totalActiveUsersChartData.value = {
281283
labels: data.map((m: Metrics) => m.day),

0 commit comments

Comments
 (0)