Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Commit 9f81fbb

Browse files
Apply suggestions from code review
Co-Authored-By: Jeff Rafter <jeffrafter@github.com>
1 parent e274ea1 commit 9f81fbb

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

app/controllers/orgs/rosters_controller.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,12 @@ def edit_entry
137137

138138
# rubocop:disable Metrics/AbcSize
139139
def add_students
140-
# channel = AddStudentsToRosterChannel.channel(roster_id: current_roster.id, user_id: current_user.id)
141140
params[:lms_user_ids].split! if params[:lms_user_ids].is_a? String
142141
lms_user_ids = Array.wrap(params[:lms_user_ids])
143142

144143
identifiers = params[:identifiers].split("\r\n").reject(&:blank?)
145144
job_info = AddStudentsToRosterJob.perform_later(identifiers, current_roster, current_user, lms_user_ids)
146145
render json: { job_info: job_info }
147-
# redirect_to roster_path(current_organization, anchor: "new-student-modal")
148146
end
149147
# rubocop:enable Metrics/AbcSize
150148

app/jobs/add_students_to_roster_job.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ class AddStudentsToRosterJob < ApplicationJob
1414
# rubocop:disable MethodLength
1515
def perform(identifiers, roster, user, lms_user_ids = [])
1616
channel = AddStudentsToRosterChannel.channel(roster_id: roster.id, user_id: user.id)
17-
# ActionCable.server.broadcast(channel, status: "update_started")
1817

1918
identifiers = add_suffix_to_duplicates!(identifiers, roster)
2019
invalid_roster_entries =

0 commit comments

Comments
 (0)